[dev.icinga.com #2494] Configuration Module only #740

Closed
icinga-migration opened this Issue Apr 3, 2012 · 8 comments

Projects

None yet

1 participant

@icinga-migration
Member

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2494

Created by mhein on 2012-04-03 06:33:07 +00:00

Assignee: mhein
Status: Resolved (closed on 2012-04-24 14:47:39 +00:00)
Target Version: 1.7
Last Update: 2012-04-24 14:47:38 +00:00 (in Redmine)


  • As a user I want to overwrite global shared icinga-web configuration from installed modules (e.g. cronks).

Maybe this could be done with a single module included last.

Changesets

2012-04-24 14:30:37 +00:00 by mhein 7ec26aa

* Added new system module included at the end fixes #2494
* Removed foreign module code

2012-04-25 15:29:10 +00:00 by mhein 871ce1d

Finished configuration module

Added configuration cronk and tested overwriting settings (refs #2494).
New default icinga action icon css class
Member

Updated by mfriedrich on 2012-04-03 07:13:35 +00:00

hm. does this imply another config change to the existing ones? is the upgrade path clear?

Member

Updated by mhein on 2012-04-03 07:21:30 +00:00

No config change. Problem is alphabetical order of modules, e.g.

  • etc/conf.d/cronks.xml is included by Module/Cronks
  • Module/Reporting for example creates a cronk by base config
  • You want to disable it means actually:
    • Cronk would be locally disabled by Module/Cronks
    • Overwritten by Module/Reporting
    • Cronk is always available

Quick fix is to disable the cronk in app/modules/Reporting/config/cronks.xml but this is not update safe.

Conclusion is to create a simple module (e.g. Config) which is initialized last in chain to include all shared configuration and allow overwriting all previous created default configuration.

Kind regards,
Marius.

Member

Updated by mfriedrich on 2012-04-03 07:23:00 +00:00

ok, so a global config master, being opt-in for those needing it.

please make sure to keep it documented (wiki) as well as tell wolfgang about the changes for the install icinga web section on docs.icinga.org

Member

Updated by mhein on 2012-04-03 07:25:06 +00:00

The change is transparent, configurations stay the same only include order changes to work like user expected.

Member

Updated by mfriedrich on 2012-04-03 07:25:51 +00:00

ok, then pingback soon enough when ready to test :)

Member

Updated by mhein on 2012-04-18 09:12:41 +00:00

  • Assigned to set to mhein
Member

Updated by mhein on 2012-04-18 09:12:53 +00:00

  • Category set to Architecture
Member

Updated by mhein on 2012-04-24 14:47:39 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 7ec26aa.

@icinga-migration icinga-migration added this to the 1.7 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment