Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3431] Icinga-web update 1.8 - Custom cronks don't work anymore #960

Closed
icinga-migration opened this issue Nov 9, 2012 · 33 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Nov 9, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3431

Created by ossmon on 2012-11-09 14:21:14 +00:00

Assignee: mhein
Status: Resolved (closed on 2013-04-08 12:40:17 +00:00)
Target Version: 1.9
Last Update: 2013-04-09 08:39:40 +00:00 (in Redmine)

Icinga Version: 1.8.1
Icinga Web Version: 1.8.0
IDO Version: 1.8.1
OS Version: RHEL 6.1
DB Type: MySQL
DB Version: 5.1.61
Browser Version: Firefox 11

After the update, many of our custom cronks (i didn't check all) are no more working.

In the screenshot an example of a copy of the service status of version 1.7.2 (without filtering) that is loaded in 1.8.0.

CustomCronks.JPG

We have over 150 custom cronks and i am afraid that if i do the update to 1.8.0 in the production, all our custom cronks will not work anymore.

Attachments

Changesets

2012-12-11 15:10:52 +00:00 by mhein 509f00f

Remove native state

This state handles auto added columns and not existing
ones from templates, refs #3431

2013-04-03 13:56:25 +00:00 by mhein 7a9b936

Icinga-web update 1.8 - Custom cronks don't work anymore

Add phing task to run upgrade on the cronks format to
add missing "event-sub-frame" column.

fixes #3431

2013-04-05 09:54:27 +00:00 by mhein 46f8bed

Icinga-web update 1.8 - Custom cronks don't work anymore

2nd try. Try to repair index beween nativeState and colModel

refs #3431

2013-04-08 12:38:12 +00:00 by mhein ff4c694

Icinga-web update 1.8 - Custom cronks don't work anymore

Created a build step to remove custom cronk layout. This fixes
layout problems before 1.8 to 1.8.

fixes #3431

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 9, 2012

Updated by MaHoff on 2012-11-09 16:25:40 +00:00

Same here for an update from icinga 1.7.0 to 1.8.0
This is an annoying bug!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 9, 2012

Updated by mfriedrich on 2012-11-09 16:31:00 +00:00

sorry for asking that dumb, but what exactly is the error? did you diff your custom cronks to the updated grid xmls to see what has been changed? is it possible to get such a custom cronk in order to reproduce your potential bug?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 9, 2012

Updated by MaHoff on 2012-11-09 16:46:37 +00:00

Hi,

on our site the "custom cronks" are simply host or service views where certain columns are hidden and others have manually adapted width and some filters where applied. These were then saved with the save as function from icinga-web.

After the update to 1.8.0 it seems that there are NEW columns (the blue box with arrow) and others are gone (info, history, ...) changing the order of columns. That's why saved cronks (aka custom cronks) are broken...

Maybe i missed some update / conversion process for the cronk views while updating 1.7.x to 1.8.0?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 9, 2012

Updated by ossmon on 2012-11-09 17:34:11 +00:00

I can confirm the analyse of MaHoff.
I have a look at the cronk table in the icinga web db where the custom cronks are stored.
The stored XML have a reference to the standard host/service template and store in a string (json ?) the changes that the customer has done.
The string contain ids that define perhaps the column number.
With the new version of the 1.8 templates, the changes defined in the "json" string don't match anymore.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 12, 2012

Updated by ossmon on 2012-11-12 07:29:33 +00:00

Hi dnsmichi,

you can easily reproduce the error if you have 2 environment (1.8 and before 1.8, in my example 1.7.2)

  1. load the service status cronk in both environment
  2. save the cronk (without modification), for example as ServiceStatus2 in both environment
  3. get the internal name of both cronks (right click on the cronk and choose menu 'Get CronkUrl'). The last parameter in the url is the name.
  4. take an SQL client (for example phpmyadmin) and go to the table cronk in the 1.7.2 icinga-web db. Search for the row with the new cronk and copy the content of the cronk_xml column
  5. take an SQL client (for example phpmyadmin) and go to the table cronk in the 1.8 icinga-web db. Search for the row with the new cronk and replace the 1.8 xml content with the 1.7.2 xml content in the cronk_xml column
  6. close the ServiceStatus2 in your 1.8 environment and reopen the grid. And you see that it is no more working.

If you don't have an before 1.8 environment, i append the content of the cronk_xml column.

    false
    false
    0
    
      icinga-service-template
      1
    
    ServiceStatus2
    ServiceStatus2
    my
    cronks.0
    Cronks
    System.ViewProc
    {"nativeState":{"columns":[{"id":"checker","width":20},{"id":1,"width":25},{"id":2,"width":70,"hidden":true},{"id":3,"width":118,"hidden":true,"sortable":true},{"id":4,"width":118,"hidden":true},{"id":5,"width":118,"hidden":true,"sortable":true},{"id":6,"width":118,"hidden":true,"sortable":true},{"id":7,"width":118,"hidden":true,"sortable":true},{"id":8,"width":118,"sortable":true},{"id":9,"width":118,"hidden":true,"sortable":true},{"id":10,"width":22},{"id":11,"width":22},{"id":12,"width":22},{"id":13,"width":55},{"id":14,"width":22},{"id":15,"width":22},{"id":16,"width":22},{"id":17,"width":100,"sortable":true},{"id":18,"width":118,"sortable":true},{"id":19,"width":118,"sortable":true},{"id":20,"width":59},{"id":21,"width":118},{"id":22,"width":100,"sortable":true}],"sort":{"field":"host_name","direction":"ASC"},"group":"host_name"},"filter_params":{},"filter_types":{},"store_origin_params":{},"sortToggle":{"host_name":"ASC"},"sortInfo":{"field":"host_name","direction":"ASC"},"colModel":{"groupField":"host_name","columns":[{"hidden":false,"width":25,"dataIndex":"service_icon","id":1,"sortable":false},{"hidden":true,"width":70,"dataIndex":"instance_name","id":2,"sortable":false},{"hidden":true,"width":118,"dataIndex":"host_object_id","id":3,"sortable":true},{"hidden":true,"width":118,"dataIndex":"service_object_id","id":4,"sortable":false},{"hidden":true,"width":118,"dataIndex":"host_name","id":5,"sortable":true},{"hidden":true,"width":118,"dataIndex":"host_alias","id":6,"sortable":true},{"hidden":true,"width":118,"dataIndex":"host_display_name","id":7,"sortable":true},{"hidden":false,"width":118,"dataIndex":"service_name","id":8,"sortable":true},{"hidden":true,"width":118,"dataIndex":"service_display_name","id":9,"sortable":true},{"hidden":false,"width":22,"dataIndex":"comments","id":10,"sortable":false},{"hidden":false,"width":22,"dataIndex":"ig_service_link","id":11,"sortable":false},{"hidden":false,"width":22,"dataIndex":"pnp4nagios_service_image_hover","id":12,"sortable":false},{"hidden":false,"width":55,"dataIndex":"pnp4nagios_service_link","id":13,"sortable":false},{"hidden":false,"width":22,"dataIndex":"service_info","id":14,"sortable":false},{"hidden":false,"width":22,"dataIndex":"service_history_link","id":15,"sortable":false},{"hidden":false,"width":22,"dataIndex":"service_to_host_link","id":16,"sortable":false},{"hidden":false,"width":100,"dataIndex":"service_status","id":17,"sortable":true},{"hidden":false,"width":118,"dataIndex":"service_last_check","id":18,"sortable":true},{"hidden":false,"width":118,"dataIndex":"service_duration","id":19,"sortable":true},{"hidden":false,"width":59,"dataIndex":"service_info_icons","id":20,"sortable":false},{"hidden":false,"width":118,"dataIndex":"plugin_output","id":21,"sortable":false},{"hidden":false,"width":100,"dataIndex":"service_check_attempt","id":22,"sortable":true}],"groupDir":"ASC","groupOnSort":true},"autoRefresh":1}
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 20, 2012

Updated by ossmon on 2012-11-20 07:25:37 +00:00

Any Idea ?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 20, 2012

Updated by mfriedrich on 2012-11-20 16:32:14 +00:00

  • File added icinga_web_1.8_custom_cronks_new_schema.png
  • File added icinga_web_1.8_custom_cronks_old_schema_columns_broken.png
  • created a backup of my existing 1.8 icinga_web db, then dropped and created the database.
  • checked out r1.7 from git, imported etc/schema/mysq.sql, ran the icinga_web install script i'm using for dev installs.
  • created hoststatus cronk with filter "status is not up" and saved as hoststatus2.
  • dumped the database into backup sql again for 1.7

1.7.2 cronk in db

|        1 | CUSTOM-gridHostView694 | HostStatus2 | 3431              | 

  
    false
    false
    0
    
      icinga-host-template
      1
    
    HostStatus2
    3431
    data
    cronks.0
    Cronks
    System.ViewProc
    {"nativeState":{"columns":[{"id":"checker","width":20},{"id":1,"width":25},{"id":2,"width":90,"hidden":true},{"id":3,"width":150,"hidden":true,"sortable":true},{"id":4,"width":150,"sortable":true},{"id":5,"width":150,"hidden":true,"sortable":true},{"id":6,"width":150,"hidden":true,"sortable":true},{"id":7,"width":22},{"id":8,"width":22},{"id":9,"width":55},{"id":10,"width":22},{"id":11,"width":22},{"id":12,"width":22},{"id":13,"width":100,"sortable":true},{"id":14,"width":150,"sortable":true},{"id":15,"width":150,"sortable":true},{"id":16,"width":75},{"id":17,"width":150},{"id":18,"width":150,"sortable":true},{"id":19,"width":150}]},"filter_params":{"f[host_status-operator]":"51","f[host_status-value]":"0"},"filter_types":{"host_status":{"fId":5,"fType":"host_status","fLabel":"Status"}},"store_origin_params":{},"sortToggle":{},"colModel":{"groupField":null,"columns":[{"hidden":false,"width":25,"dataIndex":"host_icon","id":1,"sortable":false},{"hidden":true,"width":90,"dataIndex":"instance_name","id":2,"sortable":false},{"hidden":true,"width":150,"dataIndex":"host_object_id","id":3,"sortable":true},{"hidden":false,"width":150,"dataIndex":"host_name","id":4,"sortable":true},{"hidden":true,"width":150,"dataIndex":"host_alias","id":5,"sortable":true},{"hidden":true,"width":150,"dataIndex":"host_display_name","id":6,"sortable":true},{"hidden":false,"width":22,"dataIndex":"comments","id":7,"sortable":false},{"hidden":false,"width":22,"dataIndex":"pnp4nagios_host_image_hover","id":8,"sortable":false},{"hidden":false,"width":55,"dataIndex":"pnp4nagios_host_link","id":9,"sortable":false},{"hidden":false,"width":22,"dataIndex":"host_info","id":10,"sortable":false},{"hidden":false,"width":22,"dataIndex":"host_history_link","id":11,"sortable":false},{"hidden":false,"width":22,"dataIndex":"host_statusmap_link","id":12,"sortable":false},{"hidden":false,"width":100,"dataIndex":"host_status","id":13,"sortable":true},{"hidden":false,"width":150,"dataIndex":"host_last_check","id":14,"sortable":true},{"hidden":false,"width":150,"dataIndex":"host_duration","id":15,"sortable":true},{"hidden":false,"width":75,"dataIndex":"host_info_icons","id":16,"sortable":false},{"hidden":false,"width":150,"dataIndex":"plugin_output","id":17,"sortable":false},{"hidden":false,"width":150,"dataIndex":"check_attempt","id":18,"sortable":true},{"hidden":false,"width":150,"dataIndex":"max_attempt","id":19,"sortable":false}]},"autoRefresh":1}
  

 |             1 | 2012-11-20 16:12:40 | 2012-11-20 16:12:40 |
  • drop/create database, import backup schema 1.8, run 1.8 install script
  • created hoststatus cronk with filter "status is not up" and saved as hoststatus2 (modified it, that's why the timestamps differ)
|        1 | CUSTOM-gridHostView693 | HostStatus2 | 3431              | 

  
    false
    false
    0
    
      icinga-host-template
      1
    
    HostStatus2
    3431
    data
    cronks.0
    Cronks
    System.ViewProc
    {"nativeState":{"columns":[{"id":"checker","width":20},{"id":"event-sub-frame","width":20},{"id":0,"width":25},{"id":1,"width":87,"hidden":true},{"id":2,"width":145,"hidden":true,"sortable":true},{"id":3,"width":145,"sortable":true},{"id":4,"width":145,"hidden":true,"sortable":true},{"id":5,"width":145,"hidden":true,"sortable":true},{"id":6,"width":22},{"id":7,"width":100,"sortable":true},{"id":8,"width":145,"sortable":true},{"id":9,"width":145,"sortable":true},{"id":10,"width":72},{"id":11,"width":145},{"id":12,"width":145,"sortable":true},{"id":13,"width":145},{"id":15,"width":25},{"id":14,"width":145}],"sort":{"field":"host_object_id","direction":"ASC"}},"filter_params":{"f[host_status-operator]":"51","f[host_status-value]":"0"},"filter_types":{"host_status":{"api_keyfield":"","api_target":"","api_valuefield":"","enabled":true,"id":"host_status","label":"Status","name":"host_status","operator_type":"","subtype":"appkit.ext.filter.hoststatus","type":"extjs"}},"store_origin_params":{},"sortToggle":{},"sortInfo":{"field":"host_object_id","direction":"ASC"},"colModel":{"groupField":null,"columns":[{"width":25,"dataIndex":"host_icon","id":0,"sortable":false},{"hidden":true,"width":87,"dataIndex":"instance_name","id":1,"sortable":false},{"hidden":true,"width":145,"dataIndex":"host_object_id","id":2,"sortable":true},{"width":145,"dataIndex":"host_name","id":3,"sortable":true},{"hidden":true,"width":145,"dataIndex":"host_alias","id":4,"sortable":true},{"hidden":true,"width":145,"dataIndex":"host_display_name","id":5,"sortable":true},{"width":22,"dataIndex":"comments","id":6,"sortable":false},{"width":100,"dataIndex":"host_status","id":7,"sortable":true},{"width":145,"dataIndex":"host_last_check","id":8,"sortable":true},{"width":145,"dataIndex":"host_duration","id":9,"sortable":true},{"width":72,"dataIndex":"host_info_icons","id":10,"sortable":false},{"width":145,"dataIndex":"plugin_output","id":11,"sortable":false},{"width":145,"dataIndex":"check_attempt","id":12,"sortable":true},{"width":145,"dataIndex":"max_attempt","id":13,"sortable":false},{"width":145,"dataIndex":"process_performance_data","id":14,"sortable":false},{"width":25,"dataIndex":"__","id":15,"sortable":false},{"dataIndex":"id"},{"width":20,"dataIndex":"id","id":"event-sub-frame","sortable":false}]},"autoRefresh":1}
  

 |             1 |            0 | 2012-11-20 16:02:22 | 2012-11-20 16:18:41 |

now for some upgrade tests

  • truncate table cronks;
  • from the saved icinga_web db take the insert statement for the created cronk but modify it a bit as
    `cronk_system` tinyint(1) DEFAULT '0',
    is new to the game. also, increment the id to 2.
INSERT INTO `cronk` VALUES (2,'CUSTOM-gridHostView694','HostStatus2','3431','\n\n  \n    false\n    false\n    0\n    \n      icinga-host-template\n      1\n    \n    HostStatus2\n    3431\n    data\n    cronks.0\n    Cronks\n    System.ViewProc\n    {\"nativeState\":{\"columns\":[{\"id\":\"checker\",\"width\":20},{\"id\":1,\"width\":25},{\"id\":2,\"width\":90,\"hidden\":true},{\"id\":3,\"width\":150,\"hidden\":true,\"sortable\":true},{\"id\":4,\"width\":150,\"sortable\":true},{\"id\":5,\"width\":150,\"hidden\":true,\"sortable\":true},{\"id\":6,\"width\":150,\"hidden\":true,\"sortable\":true},{\"id\":7,\"width\":22},{\"id\":8,\"width\":22},{\"id\":9,\"width\":55},{\"id\":10,\"width\":22},{\"id\":11,\"width\":22},{\"id\":12,\"width\":22},{\"id\":13,\"width\":100,\"sortable\":true},{\"id\":14,\"width\":150,\"sortable\":true},{\"id\":15,\"width\":150,\"sortable\":true},{\"id\":16,\"width\":75},{\"id\":17,\"width\":150},{\"id\":18,\"width\":150,\"sortable\":true},{\"id\":19,\"width\":150}]},\"filter_params\":{\"f[host_status-operator]\":\"51\",\"f[host_status-value]\":\"0\"},\"filter_types\":{\"host_status\":{\"fId\":5,\"fType\":\"host_status\",\"fLabel\":\"Status\"}},\"store_origin_params\":{},\"sortToggle\":{},\"colModel\":{\"groupField\":null,\"columns\":[{\"hidden\":false,\"width\":25,\"dataIndex\":\"host_icon\",\"id\":1,\"sortable\":false},{\"hidden\":true,\"width\":90,\"dataIndex\":\"instance_name\",\"id\":2,\"sortable\":false},{\"hidden\":true,\"width\":150,\"dataIndex\":\"host_object_id\",\"id\":3,\"sortable\":true},{\"hidden\":false,\"width\":150,\"dataIndex\":\"host_name\",\"id\":4,\"sortable\":true},{\"hidden\":true,\"width\":150,\"dataIndex\":\"host_alias\",\"id\":5,\"sortable\":true},{\"hidden\":true,\"width\":150,\"dataIndex\":\"host_display_name\",\"id\":6,\"sortable\":true},{\"hidden\":false,\"width\":22,\"dataIndex\":\"comments\",\"id\":7,\"sortable\":false},{\"hidden\":false,\"width\":22,\"dataIndex\":\"pnp4nagios_host_image_hover\",\"id\":8,\"sortable\":false},{\"hidden\":false,\"width\":55,\"dataIndex\":\"pnp4nagios_host_link\",\"id\":9,\"sortable\":false},{\"hidden\":false,\"width\":22,\"dataIndex\":\"host_info\",\"id\":10,\"sortable\":false},{\"hidden\":false,\"width\":22,\"dataIndex\":\"host_history_link\",\"id\":11,\"sortable\":false},{\"hidden\":false,\"width\":22,\"dataIndex\":\"host_statusmap_link\",\"id\":12,\"sortable\":false},{\"hidden\":false,\"width\":100,\"dataIndex\":\"host_status\",\"id\":13,\"sortable\":true},{\"hidden\":false,\"width\":150,\"dataIndex\":\"host_last_check\",\"id\":14,\"sortable\":true},{\"hidden\":false,\"width\":150,\"dataIndex\":\"host_duration\",\"id\":15,\"sortable\":true},{\"hidden\":false,\"width\":75,\"dataIndex\":\"host_info_icons\",\"id\":16,\"sortable\":false},{\"hidden\":false,\"width\":150,\"dataIndex\":\"plugin_output\",\"id\":17,\"sortable\":false},{\"hidden\":false,\"width\":150,\"dataIndex\":\"check_attempt\",\"id\":18,\"sortable\":true},{\"hidden\":false,\"width\":150,\"dataIndex\":\"max_attempt\",\"id\":19,\"sortable\":false}]},\"autoRefresh\":1}\n  \n\n',1,'','2012-11-20 16:12:40','2012-11-20 16:12:40');

having the imported cronk available, open both.

the one created with 1.8

icinga_web_1.8_custom_cronks_new_schema.png

the one created with 1.7.2 and imported into 1.8

icinga_web_1.8_custom_cronks_old_schema_columns_broken.png

so this is reproducable.

though, i have no idea how to transform the old column ids into the new ones in order to make that fit (dump the sql with xml, sed it, reimport it?)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 24, 2012

Updated by mfriedrich on 2012-11-24 21:01:50 +00:00

  • File added icinga_web_custom_cronk_expert_mode.png
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 4, 2012

Updated by ossmon on 2012-12-04 11:29:03 +00:00

Have the icinga-web developers an idea how we can solve the problems ?
It's very annoying if we have to delete our 150 custom cronks and recreate them manually.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 4, 2012

Updated by mfriedrich on 2012-12-04 11:31:06 +00:00

sorry, forgot to update the issue. yes we are aware of it, and no, we do not have a suitable solution yet. it's a pity that it happened, but sorry, the timetable is rather full til the end of the year.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 11, 2012

Updated by mhein on 2012-12-11 10:22:28 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mhein
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 2, 2013

Updated by ossmon on 2013-01-02 14:17:46 +00:00

Hi Marius,

i saw in the git that you have done some patches for this problem.
(see https://git.icinga.org/?p=icinga-web.git;a=commit;h=509f00f30228debd49a49f4a2c6556bc536056e4)

Is the problem with this patch solved and should i test it ?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 2, 2013

Updated by mhein on 2013-01-02 14:28:48 +00:00

  • Target Version set to 1.9

Hi ossmon.

Sorry, this solves the issue only temporarily and creates also some new problems ;-) The newest version is therefore jmosshammer/1.8.2 where this commit is removed.

The problem is that this is really a big big change. The plan is to fix till 1.9.

Kind regards,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 3, 2013

Updated by mhein on 2013-04-03 13:57:19 +00:00

  • Subject changed from Icinga-web update 1.8 - Custom cronks don't work anymore !! to Icinga-web update 1.8 - Custom cronks don't work anymore
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 3, 2013

Updated by mhein on 2013-04-03 14:01:39 +00:00

Current next branch can fix old cronk format by phing build target:

# icinga-web configured source
$ cd etc/
$ ../bin/phing upgrade-cronk-to18

This step add missing event column to existing columns at right position.

Kind regards,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 3, 2013

Updated by mhein on 2013-04-03 14:18:19 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 4340a5df44f1a09d3d852683764d9c6f0e1a797a.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by ossmon on 2013-04-04 08:17:53 +00:00

Hi Marius,
can you say what the command "phing upgrade-cronk-to18" is doing ? only patch the db table "cronk" ?
Thanks.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by ossmon on 2013-04-04 08:45:45 +00:00

  • File added CustomCronksAfterPhing.JPG

Hi Marius,

i've tested your patch procedure.

i loaded the cronk defined in #5 as cronk ServiceStatus2 in icinga-web 1.8.1 and ran your phing command. The command find something to do with this cronk.

$ ../bin/phing upgrade-cronk-to18
Buildfile: /home/ossmon/src/icinga-web.MariusHein.customcronk/etc/build.xml
 [property] Loading /home/ossmon/src/icinga-web.MariusHein.customcronk/etc/build.properties

icinga-web > upgrade-cronk-to18:


[upgradeCronkTo18] Testing cronk Neue Ãbersicht
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk 12345678901234
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk JJsPortal
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk JJsPortal2
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Services for...
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Problems1
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Problems1
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Hosts
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Open problems
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk xServiceHistory
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Serverräume
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk !Probleme
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk xHostHistory
[upgradeCronkTo18] Nothing to to
*[upgradeCronkTo18] Testing cronk ServiceStatus2
[upgradeCronkTo18] Columns upgraded
*[upgradeCronkTo18] Testing cronk 3_Sichten
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Editor
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Portal 2columns
[upgradeCronkTo18] Nothing to to

BUILD FINISHED

Total time: 0.7675 seconds

A second call with phing find nothing to patch.

$ ../bin/phing upgrade-cronk-to18

Buildfile: /home/ossmon/src/icinga-web.MariusHein.customcronk/etc/build.xml
 [property] Loading /home/ossmon/src/icinga-web.MariusHein.customcronk/etc/build.properties

icinga-web > upgrade-cronk-to18:

[upgradeCronkTo18] Testing cronk Neue Ãbersicht
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk 12345678901234
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk JJsPortal
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk JJsPortal2
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Services for...
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Problems1
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Problems1
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Hosts
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Open problems
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk xServiceHistory
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Serverräume
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk !Probleme
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk xHostHistory
[upgradeCronkTo18] Nothing to to
*[upgradeCronkTo18] Testing cronk ServiceStatus2
[upgradeCronkTo18] Nothing to to
*[upgradeCronkTo18] Testing cronk 3_Sichten
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Editor
[upgradeCronkTo18] Nothing to to
[upgradeCronkTo18] Testing cronk Portal 2columns
[upgradeCronkTo18] Nothing to to

BUILD FINISHED

Total time: 0.7439 seconds

But the cronk is always buggy.
I have deleted the cache and also the firefox cache

CustomCronksAfterPhing.JPG

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by mhein on 2013-04-04 09:11:49 +00:00

Hi.

Can you give me a dump of one failing cronk please? I need the cronk_xml data. Then I can check if something is missing.

Have you purged your user preferences? Maybe there are overrides for the custom cronk in your profile.

Kind regards,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by ossmon on 2013-04-04 09:15:46 +00:00

the cronk_xml data is in the post #5 in the issue

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by ossmon on 2013-04-04 09:17:36 +00:00

i've "reset" my preferences. No effect !

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by mhein on 2013-04-04 09:37:59 +00:00

  • Status changed from Resolved to Feedback
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by mhein on 2013-04-04 10:12:30 +00:00

  • Status changed from Feedback to Resolved

Applied in changeset a4408ce9ca94a6b5ba177474875c69d2ca743324.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by mfriedrich on 2013-04-04 10:56:23 +00:00

  • Status changed from Resolved to Feedback
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by ossmon on 2013-04-04 11:06:28 +00:00

Hi Marius,
should i test again ? which version ? 'next' version with the comment "Duplicates on services" ?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 4, 2013

Updated by mhein on 2013-04-04 11:15:24 +00:00

Hi.

No thanks. Nothing happened yet we just replaced the master branch which has closed this issue again. I try your cronk config later on and hopefully get a fix for this ;-)

Kind regards,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 5, 2013

Updated by mhein on 2013-04-05 10:00:21 +00:00

Hi.

Next try. I changed something in the upgrade method. If you want you can test this. But I think this is the last resort. Problem is that we have to indexes of columns, both different. The important index does not have names. So I do not know which column it is therefore I can not remove.

The missing event panel is fixed. But all obsolete click columns have to be removed manually, I think.

Kind regards,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 5, 2013

Updated by ossmon on 2013-04-05 12:07:59 +00:00

I've tested your new version.
Unfortunately it doesn't solve our problems :-(
We will have to recreate all our custom cronks in order to migrate to 1.9.
I hope you will have a working migration path for future changes in this area.
It will be very disappointing if we have to do the same experience a second time for future releases.
King regards,
Jacques.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 8, 2013

Updated by mhein on 2013-04-08 09:40:16 +00:00

Stop ;-)

We've one more try. Eric had a simple but cool idea: Maybe it helps just to drop the layout part from the cronk. In theory this could work because the default display from templates will be used.

I'll implement this step today and then we'll see what we get.

Thanks for testing and kind regards,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 8, 2013

Updated by ossmon on 2013-04-08 11:06:06 +00:00

Nice to read it !
I'am ready to test it again.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 8, 2013

Updated by mhein on 2013-04-08 12:40:17 +00:00

  • Status changed from Feedback to Resolved

Applied in changeset ff4c694.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 8, 2013

Updated by mhein on 2013-04-08 12:44:32 +00:00

Okay guys, maybe this is a good solution.

We now have a build step to drop the layout. This fixes all layout errors and reset the cronk in its origin state if opened. Just do

$ cd etc/
$ sudo ../bin/phing  drop-customcronk-layout

Now the display is not as it was before but not damaged. You can just move your columns around and press "Save cronk". That's it.

I'll hope that this is a good compromise between "full upgrade path" and "nothing" ;-)

Kind regards and thank you for testing folks,
Marius.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 9, 2013

Updated by ossmon on 2013-04-09 08:39:40 +00:00

Hi Marius,
it was a great idea from Eric!
I have tested it with 5 CUSTOM cronks and it is very better.
We can work with these cronks after the 'drop' procedure. Very fine.

Can you please do a small patch in your procedure:
-> Only the cronks with a name that begins with 'CUSTOM' should be processed !

We had a cronk named 'Editor' from BPM in the cronk table (without data in the cronk_xml column) and your procedure breaks at this cronk with an error. Then it was not possible to process the cronks defined after the BPM cronk in the table.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.