Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #3485] Setting grid filters fails with IE8 #982

Closed
icinga-migration opened this issue Dec 10, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Dec 10, 2012

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3485

Created by tgelf on 2012-12-10 15:07:17 +00:00

Assignee: (none)
Status: Resolved (closed on 2012-12-19 15:49:12 +00:00)
Target Version: 1.8.2
Last Update: 2013-02-11 17:56:47 +00:00 (in Redmine)

Icinga Version: 1.7.1
Icinga Web Version: 1.7.2
IDO Version: 1.7.1
OS Version: any
DB Type: MySQL
DB Version: 5.x
Browser Version: any

As soon as you choose a column in the filter dialog, an awful JavaScript error causes Icinga-Web to break. Usually you will no longer be able to do anything useful with Icinga-Web unless you reload the whole browser page.

I guess the problem has to be solved in app/modules/Cronks/lib/js/FilterHandler.js. There is "columnWidth: '25px'" in getRemoveComponent, 25px is not a valid value for columnWidth. Farther calculations in ExtJS willl therefore fail and return a NaN value. While other browsers cope with this, IE8 doesn't.

Just removing the columnWidh property shall fix this, a relative with doesn't make much for such a button.

Cheers,
Thomas Gelf

NB: It would be great if you could also backport this fix to the r1.7 branch.

Changesets

2012-12-19 12:54:38 +00:00 by jmosshammer b082fd5

Removed wrong columnWidth definition crashing IE (fixes #3485 ,thx tgelf)

2012-12-20 15:35:49 +00:00 by jmosshammer 44cab9f

Removed wrong columnWidth definition crashing IE (fixes #3485 ,thx tgelf)
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2012

Updated by jmosshammer on 2012-12-19 15:49:12 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset b082fd5.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2013

Updated by mfrosch on 2013-02-11 17:56:47 +00:00

  • Target Version set to 1.8.2

@icinga-migration icinga-migration added this to the 1.8.2 milestone Jan 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.