Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #5856] Legacy macros should be accessible as object attributes #1359

Closed
icinga-migration opened this issue Mar 25, 2014 · 7 comments

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Mar 25, 2014

This issue has been migrated from Redmine: https://dev.icinga.com/issues/5856

Created by tgelf on 2014-03-25 16:37:12 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2014-04-08 11:36:40 +00:00)
Target Version: 0.0.10
Last Update: 2014-04-29 12:25:28 +00:00 (in Redmine)


  • static attributes for objects
    • hosts get at least address and address6
  • static attributes do not override vars with the same name
  • static attributes are exported into backends, if set (hosts.address columns etc)
  • macro resolver: $address$ evaluates to $host.address$, but $service.vars.address$ or $host.vars.address$ wins if set
  • no more GetName() if !GetAddress()

There are several places where legacy object attributes have been transformed into macros. As they continue to have special purposes it's probably a good idea to make them accessible as object attributes. Examples:

object User {
  macros = {
    "email" = "mail@me",
    "mobile" = "+1235"
  }
}

VS

object User {
  email  = "mail@me",
  mobile = "+1235"
}

...and:

object Host {
  macros = {
    "address" = "127.0.0.1"
  }
}

VS

object Host {
  address = "127.0.0.1"
}

Cheers,
Thomas

Changesets

2014-04-08 11:23:24 +00:00 by gbeutner 0fdb9ea

Implement attributes for some well-known macros and allow macro recursion.

Refs #5856
Fixes #5959

2014-04-08 11:34:48 +00:00 by gbeutner 80778ba

Update components to use the new address fields.

Refs #5856

2014-04-08 15:20:10 +00:00 by (unknown) f1d6d77

Update the auto-discovery scripts.

Refs #5856

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 30, 2014

Updated by mfriedrich on 2014-03-30 17:03:48 +00:00

  • Target Version set to 0.0.10
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 7, 2014

Updated by mfriedrich on 2014-04-07 16:24:44 +00:00

  • Description updated
  • Priority changed from Normal to High
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 7, 2014

Updated by mfriedrich on 2014-04-07 16:25:05 +00:00

  • Status changed from New to Assigned
  • Assigned to set to gbeutner
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 8, 2014

Updated by gbeutner on 2014-04-08 11:36:40 +00:00

  • Status changed from Assigned to Resolved
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 29, 2014

Updated by mfriedrich on 2014-04-29 12:25:08 +00:00

  • Tracker changed from Bug to Support
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 29, 2014

Updated by mfriedrich on 2014-04-29 12:25:28 +00:00

  • Tracker changed from Support to Feature
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 12, 2015

Updated by mfriedrich on 2015-05-12 13:40:14 +00:00

  • Relates set to 9222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.