Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #6151] enable/disable commands do not update status tables #1525

Closed
icinga-migration opened this issue May 8, 2014 · 6 comments

Comments

@icinga-migration
Copy link
Member

commented May 8, 2014

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6151

Created by gbeutner on 2014-05-08 17:51:57 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2014-05-10 15:30:03 +00:00)
Target Version: 0.0.11
Last Update: 2014-09-16 09:19:48 +00:00 (in Redmine)

Icinga Version: 0.0.10

a) Disable checks with DISABLE_SVC_CHECK
b) active_checks_enabled is still 1 icinga icinga_servicestatus

Changesets

2014-05-10 14:24:58 +00:00 by (unknown) 07bd894

Add OnEnablePerfdataChanged signal.

Refs #6151

2014-05-10 14:52:48 +00:00 by (unknown) 76658e7

DB IDO: Add Enable* db events.

Refs #6151

2014-05-10 15:24:39 +00:00 by (unknown) 7730cc9

ModifiedAttributes for Enable* must call signals.

Refs #6151
Refs #5219

2014-05-10 15:25:44 +00:00 by (unknown) faf758e

Merge branch 'fix/db-ido-enable-signals-6151' into next

Fixes #6151

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 8, 2014

Updated by gbeutner on 2014-05-08 18:30:30 +00:00

Oh, that's because that column is only updated when the next check happens (which it never does). Duh.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 8, 2014

Updated by mfriedrich on 2014-05-08 20:17:59 +00:00

  • Subject changed from active_checks_enabled isn't being updated to enable/disable commands do not update status tables

Similar to other Enable/Disable commands where we don't have any events for db_ido.

boost::signals2::signal Checkable::OnEnableActiveChecksChanged;
boost::signals2::signal Checkable::OnEnablePassiveChecksChanged;
boost::signals2::signal Checkable::OnEnableNotificationsChanged;
boost::signals2::signal Checkable::OnEnableFlappingChanged;
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 10, 2014

Updated by mfriedrich on 2014-05-10 14:22:42 +00:00

boost::signals2::signal Checkable::OnEnablePerfdataChanged;
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 10, 2014

Updated by mfriedrich on 2014-05-10 15:24:13 +00:00

mysql> select ss.instance_id, active_checks_enabled, passive_checks_enabled, notifications_enabled,flap_detection_enabled, process_performance_data from icinga_servicestatus ss join icinga_objects oss on ss.service_object_id=oss.object_id where oss.name1='localhost' and oss.name2='disk' and oss.is_active=1;
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
| instance_id | active_checks_enabled | passive_checks_enabled | notifications_enabled | flap_detection_enabled | process_performance_data |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
|           3 |                     1 |                      1 |                     1 |                      1 |                        1 |
|           2 |                     1 |                      1 |                     1 |                      1 |                        1 |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
2 rows in set (0.00 sec)

mysql> select ss.instance_id, active_checks_enabled, passive_checks_enabled, notifications_enabled,flap_detection_enabled, process_performance_data from icinga_servicestatus ss join icinga_objects oss on ss.service_object_id=oss.object_id where oss.name1='localhost' and oss.name2='disk' and oss.is_active=1;
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
| instance_id | active_checks_enabled | passive_checks_enabled | notifications_enabled | flap_detection_enabled | process_performance_data |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
|           3 |                     1 |                      1 |                     1 |                      1 |                        1 |
|           2 |                     0 |                      1 |                     1 |                      1 |                        1 |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
2 rows in set (0.00 sec)

mysql> select ss.instance_id, active_checks_enabled, passive_checks_enabled, notifications_enabled,flap_detection_enabled, process_performance_data from icinga_servicestatus ss join icinga_objects oss on ss.service_object_id=oss.object_id where oss.name1='localhost' and oss.name2='disk' and oss.is_active=1;
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
| instance_id | active_checks_enabled | passive_checks_enabled | notifications_enabled | flap_detection_enabled | process_performance_data |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
|           3 |                     1 |                      1 |                     1 |                      1 |                        1 |
|           2 |                     0 |                      0 |                     1 |                      1 |                        1 |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
2 rows in set (0.00 sec)

mysql> select ss.instance_id, active_checks_enabled, passive_checks_enabled, notifications_enabled,flap_detection_enabled, process_performance_data from icinga_servicestatus ss join icinga_objects oss on ss.service_object_id=oss.object_id where oss.name1='localhost' and oss.name2='disk' and oss.is_active=1;
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
| instance_id | active_checks_enabled | passive_checks_enabled | notifications_enabled | flap_detection_enabled | process_performance_data |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
|           3 |                     1 |                      1 |                     1 |                      1 |                        1 |
|           2 |                     0 |                      0 |                     0 |                      1 |                        1 |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
2 rows in set (0.00 sec)

mysql> select ss.instance_id, active_checks_enabled, passive_checks_enabled, notifications_enabled,flap_detection_enabled, process_performance_data from icinga_servicestatus ss join icinga_objects oss on ss.service_object_id=oss.object_id where oss.name1='localhost' and oss.name2='disk' and oss.is_active=1;
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
| instance_id | active_checks_enabled | passive_checks_enabled | notifications_enabled | flap_detection_enabled | process_performance_data |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
|           3 |                     1 |                      1 |                     1 |                      1 |                        1 |
|           2 |                     0 |                      0 |                     0 |                      0 |                        1 |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
2 rows in set (0.00 sec)

Resetting the attributes did not trigger any events. That is partly solved but the Vars() are blocked by #5219

mysql> select ss.instance_id, active_checks_enabled, passive_checks_enabled, notifications_enabled,flap_detection_enabled, process_performance_data from icinga_servicestatus ss join icinga_objects oss on ss.service_object_id=oss.object_id where oss.name1='localhost' and oss.name2='disk' and oss.is_active=1;
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
| instance_id | active_checks_enabled | passive_checks_enabled | notifications_enabled | flap_detection_enabled | process_performance_data |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
|           3 |                     1 |                      1 |                     1 |                      1 |                        1 |
|           2 |                     1 |                      1 |                     1 |                      1 |                        1 |
+-------------+-----------------------+------------------------+-----------------------+------------------------+--------------------------+
2 rows in set (0.01 sec)
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 10, 2014

Updated by Anonymous on 2014-05-10 15:30:03 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset i2:faf758eb26c7563edeadc18eabb13800b2af37f2.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2014

Updated by mfriedrich on 2014-09-16 09:19:48 +00:00

  • Project changed from 32 to Icinga 2
  • Category set to DB IDO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.