Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #6187] Make sure that the signatures for DynamicObject::SetModifiedAttributes and {User,Checkable,...}::SetModifiedAttributes match #1537

Closed
icinga-migration opened this issue May 11, 2014 · 5 comments

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented May 11, 2014

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6187

Created by gbeutner on 2014-05-11 04:21:53 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2014-05-19 16:05:03 +00:00)
Target Version: 2.0 Beta 1
Last Update: 2014-05-19 16:05:03 +00:00 (in Redmine)

Icinga Version: 0.0.11

Changesets

2014-05-19 15:57:58 +00:00 by (unknown) 601e10c

Use CustomVarObject instead of DynamicObject for all libicinga objects.

Fixes #6187

2014-05-19 16:17:47 +00:00 by (unknown) af95181

Add MessageOrigin to OnVarsChanged.

Refs #6187
Refs #5219

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 11, 2014

Updated by gbeutner on 2014-05-11 04:26:57 +00:00

Same for SetVars.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 11, 2014

Updated by mfriedrich on 2014-05-11 09:10:48 +00:00

The problem is that SetVars would need the MessageOrigin struct supporting modified attributes in the cluster (see my comment in #5219). That would require libbase linking against libremote which shouldn't happen. Maybe the vars and modified attributes are a libicinga specific object attribute, and should be handled as such (and not polute DynamicObject). Though that would need something as

DynamicObject -> IcingaObject(vars, modattr) -> {Host,Service,...}(vars, modattr)

Imho the cleanest option, but not necessarily the best. Your thoughts on this?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 12, 2014

Updated by gbeutner on 2014-05-12 14:05:25 +00:00

  • Assigned to set to mfriedrich

JFDI. Maybe figure out if there's a better name instead of "IcingaObject".

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 16, 2014

Updated by gbeutner on 2014-05-16 09:45:40 +00:00

  • Target Version changed from 0.0.11 to 2.0 Beta 1
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 19, 2014

Updated by Anonymous on 2014-05-19 16:05:03 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 601e10c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.