Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #8401] Package for syntax highlighting #2606

Closed
icinga-migration opened this issue Feb 9, 2015 · 15 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Feb 9, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/8401

Created by mfriedrich on 2015-02-09 13:02:48 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-06-17 12:18:17 +00:00)
Target Version: 2.5.0
Last Update: 2016-06-17 12:18:17 +00:00 (in Redmine)

Backport?: Not yet backported

  • vim
  • nano

Changesets

2015-04-28 17:14:05 +00:00 by dgoetz f682b1d

Adds packages for syntax highlighting

refs #8401

2016-02-04 11:59:16 +00:00 by dgoetz dac224c

Adds packages for syntax highlighting

refs #8401

2016-02-04 12:13:23 +00:00 by mfrosch 920777d

Update vim and nano syntax docs for Debian/Ubuntu

refs #8401

2016-06-17 11:07:21 +00:00 by dgoetz 916537b

RPM: Add packages for syntax highlighting

refs #8401

2016-06-17 11:07:39 +00:00 by mfrosch af906e2

Update vim and nano syntax docs for Debian/Ubuntu

refs #8401

2016-06-17 12:16:17 +00:00 by mfriedrich ff0c44d

Update documentation for vim/nano syntax highlighting

fixes #8401

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2015

Updated by mfriedrich on 2015-04-27 14:47:42 +00:00

  • Status changed from New to Assigned
  • Assigned to set to dgoetz
  • Target Version set to 2.4.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2015

Updated by dgoetz on 2015-04-28 17:24:52 +00:00

  • Assigned to changed from dgoetz to mfrosch

Added vim-icinga2 and nano-icinga2 to the spec and changed the corresponding documentation for enabling it.

Build and installation is tested with CentOS 7 and Fedora 20. But all other rpm based distros should be fine, I only had no access to SLES 12 to verify the vim version, but should be 7.4.

lazyfrosch will create the Debian packages (and Ubuntu?). Because of the documentation change we should wait with publishing until he is finish.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 19, 2015

Updated by mfriedrich on 2015-05-19 07:57:46 +00:00

  • Target Version deleted 2.4.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2015

Updated by mfriedrich on 2015-06-26 09:13:15 +00:00

  • Target Version set to Backlog
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2015

Updated by mfriedrich on 2015-08-27 16:14:56 +00:00

Any progress?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Updated by mfrosch on 2016-02-04 10:38:22 +00:00

In Debian there is no practice to install nano- packages.

Therefor I created an vim-icinga2 package with the support for vim-addon-manager. The nanorc gets installed with icinga2-common in the correct path.

Should we do the same with RPMs?

I will update the docs here later.

Changes for Debian:
https://anonscm.debian.org/cgit/pkg-nagios/pkg-icinga2.git/commit/?id=522fca2bf7dad4108fa21082bf7a1e53e9a5b90c
https://anonscm.debian.org/cgit/pkg-nagios/pkg-icinga2.git/commit/?id=926142187843c0857facf72f5b8496a8579ee82e
https://anonscm.debian.org/cgit/pkg-nagios/pkg-icinga2.git/commit/?id=b4f5917292441906c52ecce8e2f5eaeb80ac7b6e

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Updated by dgoetz on 2016-02-04 11:08:12 +00:00

I think we should support the different distributions corresponding their ways how to handle it, so keep the nano subpackage for RPM and just tell the users in the docs would be my preferred way.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Updated by mfrosch on 2016-02-04 11:59:37 +00:00

Rebased feature/syntax-8401

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Updated by mfrosch on 2016-02-04 15:11:35 +00:00

Added my docu bits, please review

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

Updated by mfrosch on 2016-02-04 15:11:49 +00:00

  • Assigned to changed from mfrosch to mfriedrich
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2016

Updated by mfriedrich on 2016-02-25 00:29:02 +00:00

  • Status changed from Assigned to New
  • Assigned to deleted mfriedrich
  • Target Version changed from Backlog to 2.5.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2016

Updated by mfriedrich on 2016-03-22 20:39:56 +00:00

  • Relates set to 11432
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2016

Updated by mfriedrich on 2016-03-31 10:38:41 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2016

Updated by mfriedrich on 2016-06-17 12:16:03 +00:00

Review

  • vim

  • Verified the Debian package in a fresh docker container. Installed with the provided documentation, works fine.

  • Small suggestion added - ensure that syntax on is set in vimrc. By default it is off.

  • Tested the RPM package on a fresh centos docker container. Just installed "vim-icinga2", works. syntax on is already set by default.

  • nano

  • Debian package icinga2-common installed - does not work, but still requires manual inclusion in nanorc - updated the docs.

  • RPM package install plus additional nanorc inclusion as described in the docs - works.

  • Minor documentation updates (wording, formatting)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2016

Updated by mfriedrich on 2016-06-17 12:18:17 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset ff0c44d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.