New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #8685] Show state/type filter names in notice/debug log #2737

Closed
icinga-migration opened this Issue Mar 11, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Member

icinga-migration commented Mar 11, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/8685

Created by tgelf on 2015-03-11 12:11:05 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-03-19 13:20:02 +00:00)
Target Version: 2.3.3
Last Update: 2015-03-19 13:20:02 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

People trying to debug notification issues will currently find binary flag showing filter missmatches. As those flags are not that helpful it would be great to see filter names in a user-friendly "string representation".

Regards,
Thomas

Changesets

2015-03-12 16:11:24 +00:00 by (unknown) 3c94591

Show notification state/type filter names in notice/debug log

fixes #8685

2015-03-19 13:08:06 +00:00 by (unknown) 88f16ab

Use Utility::NaturalJoin for notification filter formatting

refs #8685

2015-03-19 13:09:07 +00:00 by (unknown) 6e778c4

Show notification state/type filter names in notice/debug log

fixes #8685

2015-03-19 13:09:14 +00:00 by (unknown) 6c8bc20

Use Utility::NaturalJoin for notification filter formatting

refs #8685
@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 12, 2015

Member

Updated by mfriedrich on 2015-03-12 09:56:40 +00:00

  • Subject changed from Show filter names in debug log to Show state/type filter names in notice/debug log
  • Category set to Notifications
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.4.0
  • Estimated Hours set to 2
Member

icinga-migration commented Mar 12, 2015

Updated by mfriedrich on 2015-03-12 09:56:40 +00:00

  • Subject changed from Show filter names in debug log to Show state/type filter names in notice/debug log
  • Category set to Notifications
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.4.0
  • Estimated Hours set to 2
@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 12, 2015

Member

Updated by mfriedrich on 2015-03-12 16:11:42 +00:00

I had to add some helpers formatting the states and types into regular filter names, not the capitalized ones used in interfaces. The rest gives you every little detail on debug, and also in case of a non-matching filter on notice level.

Please test that.

Member

icinga-migration commented Mar 12, 2015

Updated by mfriedrich on 2015-03-12 16:11:42 +00:00

I had to add some helpers formatting the states and types into regular filter names, not the capitalized ones used in interfaces. The rest gives you every little detail on debug, and also in case of a non-matching filter on notice level.

Please test that.

@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 12, 2015

Member

Updated by Anonymous on 2015-03-12 16:15:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 3c94591.

Member

icinga-migration commented Mar 12, 2015

Updated by Anonymous on 2015-03-12 16:15:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 3c94591.

@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 19, 2015

Member

Updated by mfriedrich on 2015-03-19 10:18:45 +00:00

  • Status changed from Resolved to Assigned
  • Target Version changed from 2.4.0 to 2.3.3
  • Backport? changed from TBD to Yes
  • Use Utility::NaturalJoin
Member

icinga-migration commented Mar 19, 2015

Updated by mfriedrich on 2015-03-19 10:18:45 +00:00

  • Status changed from Resolved to Assigned
  • Target Version changed from 2.4.0 to 2.3.3
  • Backport? changed from TBD to Yes
  • Use Utility::NaturalJoin
@icinga-migration

This comment has been minimized.

Show comment
Hide comment
@icinga-migration

icinga-migration Mar 19, 2015

Member

Updated by Anonymous on 2015-03-19 13:20:02 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset 6e778c4.

Member

icinga-migration commented Mar 19, 2015

Updated by Anonymous on 2015-03-19 13:20:02 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset 6e778c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment