Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #9236] PerfdataWriter: Better failure handling for file renames across file systems #2993
This issue has been migrated from Redmine: https://dev.icinga.com/issues/9236
Created by cark on 2015-05-07 08:43:53 +00:00
If [service|host]_temp_path and [service|host]_perfdata_path are not on the same mountpoint, performance data willnot be rotated.
Run into this problem while converting 60K services to Icinga2 and used 2 different tmpfs mountpoints for it.
2016-05-11 07:29:32 +00:00 by (unknown) 7dbd665
2016-05-11 07:32:37 +00:00 by gbeutner f7e1e4e
2016-05-12 09:09:49 +00:00 by (unknown) 88806b0
2016-05-12 09:11:00 +00:00 by gbeutner 48ea880
Updated by cark on 2015-05-13 12:43:13 +00:00
My Icinga 1 installation used one so i planned to use it for icinga2 also.
To use ramdisk is written in "Optimize Icinga Performance" (https://wiki.icinga.org/display/howtos/Optimize+Icinga+Performance)
Updated by mfriedrich on 2015-06-18 09:25:43 +00:00
Updated by jyoung15 on 2015-07-19 04:56:26 +00:00
I recently ran into this issue as well. The return value for the rename function in PerfdataWriter::RotateFile is not checked, so this error is silently ignored. Please add code to log a warning if rename returns an error (EXDEV errno 18 in this case).
Updated by jdonahue on 2015-09-08 22:19:10 +00:00
I also ran into this problem recently when moving the perfdata files to a different file system, +1 for adding a warning if the rename fails.
Updated by mfriedrich on 2016-04-07 12:08:07 +00:00
Sorry for the late response. Thanks for the patch :)
We'll also need a custom validator which checks the same device for _temp_path and_perfdata_path (stat).