[dev.icinga.com #9264] Extend CheckCommand definitions for nscp-local #3012
Comments
Updated by mfriedrich on 2015-05-13 07:22:55 +00:00
|
Updated by mfriedrich on 2015-05-19 07:57:49 +00:00
|
Updated by lbetz on 2015-06-18 14:57:15 +00:00 A proposal: object CheckCommand "nscp-local-cpu" { arguments += { vars.nscp_query = "check_cpu" vars.nscp_cpu_time = [ "1m", "5m", "15m" ] The goal, to have simple options like warning, critical for each service. And i.e. for nscp-local-nscp the time intervals as an array or string, in check_drivesize the same for drive option or in check_service to specify the services. globals.nscp_prefix = function(prefix, pmacro) { |
Updated by lbetz on 2015-08-27 07:24:09 +00:00
Next offer: |
Updated by mfriedrich on 2015-09-12 19:12:00 +00:00 If that's meant as addition, please add a git formatted patch. Furthermore all check commands use the "my-" prefix, which should be removed, shouldn't it? |
Updated by lbetz on 2015-09-12 19:28:21 +00:00 Sure, the prefix will be removed. This was just a proposal, I thought for an open discussion. If it's ok, I will push a formatted patch. |
Updated by lbetz on 2015-09-21 08:39:04 +00:00
I got now feedback, so here are the format patch for check commands:
|
Updated by mfriedrich on 2016-04-07 12:15:49 +00:00
should be changed to
|
Updated by gbeutner on 2016-06-14 06:25:55 +00:00 lbetz: What's the status for this? |
Updated by mfriedrich on 2016-06-17 12:55:28 +00:00
Simple test case for checking !macro() conditions:
|
Updated by lbetz on 2016-06-17 13:40:03 +00:00
Applied in changeset 765e91d. |
Updated by mfriedrich on 2016-06-20 08:10:05 +00:00
Extensions for -disk are missing for example in the patch file https://dev.icinga.org/attachments/2726/0001-Add-more-usable-parameters-for-check-commands.patch |
Updated by lbetz on 2016-06-20 15:41:28 +00:00
Hi Michi, here's the fix you asked for.... depends on: commit 89d1d2abf6d8342d5995b0c491eab1d8d9b8b7d0 fix check commands nscp-loca-disk and nscp-local-counter commit f10289a DB IDO: Add missing object_id index for icinga_{scheduleddowntime,comments} tables |
Updated by lbetz on 2016-06-20 15:55:03 +00:00
Applied in changeset c393a36. |
This issue has been migrated from Redmine: https://dev.icinga.com/issues/9264
Created by mfriedrich on 2015-05-13 07:22:49 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2016-06-20 15:55:03 +00:00)
Target Version: 2.5.0
Last Update: 2016-06-20 15:55:03 +00:00 (in Redmine)
Attachments
Changesets
2016-06-17 13:07:42 +00:00 by lbetz 765e91d
2016-06-20 15:46:34 +00:00 by lbetz c393a36
Relations:
The text was updated successfully, but these errors were encountered: