Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9283] Implement support for overriding check command timeout #3023

Closed
icinga-migration opened this issue May 18, 2015 · 13 comments

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented May 18, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9283

Created by aledermueller on 2015-05-18 08:52:06 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-04-07 13:10:03 +00:00)
Target Version: 2.4.5
Last Update: 2016-04-20 08:15:49 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

Hi,

please allow to use a macro for the parameter timeout within a CheckCommand definition, eg:

object CheckCommand "check_foo" {
...
  timeout = "$vars.timeout$"
...

Regards, Achim

Changesets

2016-04-07 13:07:17 +00:00 by mfriedrich 2b2e250

Implement support for overriding check command timeout

fixes #9283

2016-04-20 08:09:34 +00:00 by mfriedrich 1a21293

Implement support for overriding check command timeout

fixes #9283

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 18, 2015

Updated by gbeutner on 2015-05-18 13:53:06 +00:00

FWIW that's not a macro. I've updated your example.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented May 18, 2015

Updated by gbeutner on 2015-05-18 13:53:24 +00:00

  • Description updated
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 9, 2015

Updated by mfriedrich on 2015-06-09 07:58:32 +00:00

Imho we should think of function support for some/all object attributes, which would allow the following at runtime:

timeout = macro("$vars.timeout$")

or, by accessing the host's scope passed from the macro resolver.

timeout = {{ return host.vars.timeout }}
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 18, 2015

Updated by mfriedrich on 2015-06-18 09:16:40 +00:00

  • Subject changed from Evaluating macros in CheckCommand definitions to Allow function usage in object attributes
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 23, 2015

Updated by mfriedrich on 2015-06-23 13:30:50 +00:00

  • Target Version set to Backlog
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 5, 2015

Updated by mfriedrich on 2015-09-05 15:22:32 +00:00

  • Priority changed from Normal to High
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 29, 2015

Updated by mfriedrich on 2015-09-29 12:51:44 +00:00

  • Relates set to 10240
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Oct 31, 2015

Updated by mfriedrich on 2015-10-31 12:17:50 +00:00

  • Relates set to 10504
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 2, 2015

Updated by jflach on 2015-11-02 09:16:34 +00:00

  • Relates set to 10200
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 30, 2016

Updated by gbeutner on 2016-03-30 06:20:07 +00:00

  • Relates deleted 10200
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 7, 2016

Updated by mfriedrich on 2016-04-07 13:06:56 +00:00

  • Subject changed from Allow function usage in object attributes to Implement support for overriding check command timeout

  • Assigned to set to mfriedrich

  • Target Version changed from Backlog to 2.4.5

    object Host "timeout-host" {
    check_command = "hostalive"
    address = "8.8.8.8"

    check_timeout = 1s
    

    }

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 7, 2016

Updated by mfriedrich on 2016-04-07 13:10:03 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 2b2e250.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 20, 2016

Updated by gbeutner on 2016-04-20 08:15:49 +00:00

  • Backport? changed from Not yet backported to Already backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.