Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9450] node setup: indent accept_config and accept_commands #3084

Closed
icinga-migration opened this issue Jun 18, 2015 · 3 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jun 18, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9450

Created by bebehei on 2015-06-18 17:31:42 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-06-19 07:24:27 +00:00)
Target Version: 2.3.6
Last Update: 2015-06-19 07:24:39 +00:00 (in Redmine)

Icinga Version: r2.3.5-1
Backport?: Already backported
Include in Changelog: 1

Patch at #35

This indents accept_config when generated by node setup.

I additionally thought, it would be cool, when these are also separeted with an additional line.

Changesets

2015-06-19 07:07:51 +00:00 by bebehei 7cd0077

node setup: indent accept_config and accept_commands

fixes #9450

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2015-06-19 07:24:08 +00:00 by bebehei 48dec15

node setup: indent accept_config and accept_commands

fixes #9450

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 19, 2015

Updated by mfriedrich on 2015-06-19 07:07:19 +00:00

  • Subject changed from indent accept_config and accept_commands to node setup: indent accept_config and accept_commands
  • Category set to CLI
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.4.0
  • Estimated Hours set to 0.1

Thanks for your contribution and also for creating an issue with the github patch :)

Looks valid to me, as the node wizard command does the very same.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 19, 2015

Updated by bebehei on 2015-06-19 07:24:27 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset 7cd0077.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 19, 2015

Updated by mfriedrich on 2015-06-19 07:24:39 +00:00

  • Target Version changed from 2.4.0 to 2.3.6
  • Backport? changed from TBD to Yes
@icinga-migration icinga-migration added this to the 2.3.6 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.