Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9463] Incorrect check_ping.exe parameter in the ITL #3091

Closed
icinga-migration opened this issue Jun 20, 2015 · 10 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jun 20, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9463

Created by charke on 2015-06-20 15:04:25 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-07-07 13:50:03 +00:00)
Target Version: 2.3.6
Last Update: 2015-07-07 13:50:03 +00:00 (in Redmine)

Icinga Version: 2.3.5
Backport?: Already backported
Include in Changelog: 1

Got an UNKNOWN "service problem" message concerning

"ping4 on "

Changing parameter "-p" to "-n" in template CheckCommand "ping-common-windows" solved that issue. (see file attached on line 159).

Attachments

Changesets

2015-07-07 13:42:47 +00:00 by charke ebb6efe

ITL: Fix incorrect check_ping.exe parameter

fixes #9463

2015-07-07 13:43:37 +00:00 by (unknown) 1cba11d

Update AUTHORS

refs #9463

2015-07-07 13:44:58 +00:00 by charke 2259024

ITL: Fix incorrect check_ping.exe parameter

fixes #9463

2015-07-07 13:45:03 +00:00 by (unknown) e45ecaf

Update AUTHORS

refs #9463

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 22, 2015

Updated by gbeutner on 2015-06-22 06:02:33 +00:00

  • Status changed from New to Assigned
  • Assigned to set to jflach
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 22, 2015

Updated by jflach on 2015-06-22 14:45:26 +00:00

  • Status changed from Assigned to Feedback

Since you already found and fixed the problem you can create a patch which I would then sign off. This way you would be mentioned as a contributor.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 22, 2015

Updated by jflach on 2015-06-22 14:46:14 +00:00

  • Assigned to changed from jflach to charke
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 1, 2015

Updated by charke on 2015-07-01 07:18:08 +00:00

I sent the patch to your netways.de email address on June 23. When will you sign it off?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 1, 2015

Updated by mfriedrich on 2015-07-01 07:28:09 +00:00

Please attach the patch here instead of sending private mails.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 1, 2015

Updated by charke on 2015-07-01 11:05:21 +00:00

  • File added 0001-Fixes-#9463.patch

Thank you for your quick reply, you will find the patch in the attachment.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 7, 2015

Updated by mfriedrich on 2015-07-07 13:44:29 +00:00

  • Status changed from Feedback to Assigned
  • Target Version set to 2.3.6
  • Backport? changed from TBD to Yes

Thanks, for some reason your patch is not valid (try 'git format-patch -1' and always add a subject). I've modified it for you now once, to get this done for 2.3.6.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 7, 2015

Updated by mfriedrich on 2015-07-07 13:45:31 +00:00

  • Assigned to changed from charke to mfriedrich
  • Estimated Hours set to 0.1
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 7, 2015

Updated by charke on 2015-07-07 13:50:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset ebb6efe.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 15, 2015

Updated by mfriedrich on 2015-07-15 20:42:32 +00:00

  • Relates set to 9637
@icinga-migration icinga-migration added this to the 2.3.6 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.