Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9527] CheckCommand for check_interfaces #3111

Closed
icinga-migration opened this issue Jun 29, 2015 · 13 comments
Closed

[dev.icinga.com #9527] CheckCommand for check_interfaces #3111

icinga-migration opened this issue Jun 29, 2015 · 13 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jun 29, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9527

Created by lbetz on 2015-06-29 15:08:38 +00:00

Assignee: lbetz
Status: Resolved (closed on 2015-08-03 16:10:03 +00:00)
Target Version: 2.3.9
Last Update: 2015-08-17 06:58:56 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

Contrib plugin from https://www.netways.org/projects/check-interfaces

Attachments

Changesets

2015-08-03 16:05:09 +00:00 by lbetz 8d11b74

ITL: Add check command check_interfaces

fixes #9527

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2015-08-17 06:58:14 +00:00 by lbetz 49cf0bb

ITL: Add check command check_interfaces

fixes #9527

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jun 30, 2015

Updated by gbeutner on 2015-06-30 06:23:52 +00:00

  • Status changed from New to Assigned
  • Assigned to set to lbetz

Please attach a patch which is in the same format that's used by 'git format-patch'.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 6, 2015

Updated by lbetz on 2015-07-06 09:32:21 +00:00

  • File added 0001-added-CheckCommand-interfaces-to-itl.patch

git format-patch -1 83f6e3764a74dd7d11675c0670cedab195a84d1f

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 6, 2015

Updated by mfriedrich on 2015-07-06 15:05:59 +00:00

Please fix the indent -> 1 tab instead of 2 spaces.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 6, 2015

Updated by lbetz on 2015-07-06 16:20:19 +00:00

I added it to a file named itl/plugins-contrib.d/network-components.conf with to more check command. This to also have an ident of two spaces? So should I correct all of them?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 7, 2015

Updated by mfriedrich on 2015-07-07 07:50:13 +00:00

  • Status changed from Assigned to Feedback

The indent is totally fine in this file. I'd say your editor cannot handle the indent properly and always saves 2 spaces.

Aside from that, please create an issue and git patch for each new CheckCommand and kindly ask Dirk for the final review.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 7, 2015

Updated by lbetz on 2015-07-07 12:30:43 +00:00

  • File added 0001-added-CheckCommand-interfaces-to-itl.patch

Sorry Michi,

had to be the temperature yesterday. Copy'n'paste is a worst thing.... now, next try with set tabs manually.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 24, 2015

Updated by mfriedrich on 2015-07-24 18:27:53 +00:00

  • Status changed from Feedback to New
  • Assigned to deleted lbetz
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 27, 2015

Updated by lbetz on 2015-07-27 08:56:25 +00:00

  • File added 0001-added-check_command-for-check_interfaces.patch

next run...

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jul 27, 2015

Updated by lbetz on 2015-07-27 14:19:03 +00:00

damn again.It's in a wrong category, too. I will correct this.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 2, 2015

Updated by lbetz on 2015-08-02 05:37:45 +00:00

  • File added 0001-added-check-command-for-check_interfaces.patch

correct ident and doc section.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 3, 2015

Updated by mfriedrich on 2015-08-03 16:05:55 +00:00

  • Status changed from New to Assigned
  • Assigned to set to lbetz
  • Target Version set to 2.4.0
  • Estimated Hours set to 0.1

Merged, thanks.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 3, 2015

Updated by lbetz on 2015-08-03 16:10:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 8d11b74.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Aug 17, 2015

Updated by gbeutner on 2015-08-17 06:58:56 +00:00

  • Target Version changed from 2.4.0 to 2.3.9
  • Backport? changed from TBD to Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.