Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9642] Flapping notifications are sent for hosts/services which are in a downtime #3153

Closed
icinga-migration opened this issue Jul 15, 2015 · 13 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jul 15, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9642

Created by barry.quiel on 2015-07-15 18:49:34 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-02-23 15:30:04 +00:00)
Target Version: 2.4.4
Last Update: 2016-09-19 13:21:02 +00:00 (in Redmine)

Icinga Version: 2.3.5
Backport?: Already backported
Include in Changelog: 1

A service in scheduled downtime is able to send notifications for flapping start. Should scheduled downtime suppress all notifications while downtime is active?

Screenshot of event log attached

Attachments

Changesets

2016-02-22 18:48:22 +00:00 by chrostek b223431

Fix problem notifications while flapping is active

refs #9969
refs #9642

2016-02-23 15:27:22 +00:00 by chrostek 83845e6

Fix problem notifications while flapping is active

fixes #9969
fixes #9642

2016-03-11 14:24:02 +00:00 by chrostek f5f0f7b

Fix problem notifications while flapping is active

fixes #9969
fixes #9642

Relations:

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Aug 21, 2015

Updated by mfriedrich on 2015-08-21 18:56:33 +00:00

  • Relates set to 9969
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Aug 22, 2015

Updated by chrostek on 2015-08-22 18:16:26 +00:00

same if-block as in #9969 but not solved by my last post there.

maybe:

if (send_notification && !was_flapping && is_flapping) {
[...]
} else if (send_notification && was_flapping && !is_flapping) {
[...]
} else if (send_notification && !is_flapping && !was_flapping)
[...]

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Oct 22, 2015

Updated by MichaelT on 2015-10-22 07:09:01 +00:00

Please make was_flapping and is_flapping available to the config files. This way changes in behaviour can be set at config level if needed.

chrostek wrote:

same if-block as in #9969 but not solved by my last post there.

maybe:

if (send_notification && !was_flapping && is_flapping) {
[...]
} else if (send_notification && was_flapping && !is_flapping) {
[...]
} else if (send_notification && !is_flapping && !was_flapping)
[...]

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Oct 22, 2015

Updated by chrostek on 2015-10-22 08:12:29 +00:00

Why? I do not want to "change" the behaviour ... one essential feature of flap detection is suppressing notifications. i do not want additional config to achieve this ...

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Oct 22, 2015

Updated by MichaelT on 2015-10-22 13:49:15 +00:00

chrostek wrote:

Why? I do not want to "change" the behaviour ... one essential feature of flap detection is suppressing notifications. i do not want additional config to achieve this ...

Me neither, but I prefer to have a chance of a fix in a reasonable time.
As it is already 2 releases since the Bug report, I thought "let's make it easy to the developers". I would rather make a few changes myself now then wait another 2 releases.
Having a working flap detection seems to be pretty low on the list of priorities, and I do appreciate all the time everyone is putting into this great project!

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Oct 22, 2015

Updated by chrostek on 2015-10-22 13:57:19 +00:00

it would by nice if someone could test my patch from #9969 - if someone could confirm that it is working the developers could check it in

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by mfriedrich on 2016-02-23 15:26:20 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.4.3
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by chrostek on 2016-02-23 15:30:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 83845e6.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 24, 2016

Updated by mfriedrich on 2016-02-24 09:53:27 +00:00

  • Target Version changed from 2.4.3 to 2.4.4
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 11, 2016

Updated by mfriedrich on 2016-03-11 14:24:19 +00:00

  • Backport? changed from Not yet backported to Already backported
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 15, 2016

Updated by gbeutner on 2016-03-15 13:33:48 +00:00

  • Subject changed from Device in scheduled downtime able to send flapping start notification to Flapping notifications are sent for hosts/services which are in a downtime
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jun 7, 2016

Updated by mfriedrich on 2016-06-07 20:14:21 +00:00

  • Relates set to 11899
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Sep 19, 2016

Updated by ziesemer on 2016-09-19 13:21:02 +00:00

#12560 is a regression of this bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.