Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #9858] Gelf module: expose 'perfdata' fields for 'CHECK_RESULT' events #3237
This issue has been migrated from Redmine: https://dev.icinga.com/issues/9858
Created by daniilyar on 2015-08-06 14:30:18 +00:00
Current GELF Icinga plugin output for check results doesn't include any 'perfdata' fields. Instead GELF output includes human-readable, but not highly parseable strings (like 'shortmessage') which contains only a part of meaningful check result. This makes GELF plugin almost impossible to use for graphing and analysing Icinga check results somewhere else outside the Icinga. E.g., at popular Elasticsearch + Logstash + Kibana stack. This is very inconvenient from the point of Logstash (or any other monitoring data parsing tools coming with a Gelf input) as all data parsing tools needs input data to be highly parseable.
Also there is a bunch of Icinga internal variables which, I think, are good to be exposed in GELF plugin CHECK RESULT events, too. E.g., 'checkable->IsReachable()' field could be useful at GELF receiver side for alerting purposes.
I've made a pull request at GitHub which exposes all 'perfdata' fields and 'checkable->IsReachable()' field at GELF plugin 'CHECK RESULT' events: #43
2015-12-18 10:05:38 +00:00 by (unknown) d739675
2015-12-18 10:10:54 +00:00 by mfriedrich 5aa4700
2016-02-23 15:28:04 +00:00 by mfriedrich c256ea1
Updated by mariussturm on 2015-10-20 10:37:15 +00:00
Sorry, took me awhile to get my dev account running.
Updated by daniilyar on 2015-11-25 12:21:43 +00:00
Sorry, I didn't receive an email notification about your answer for some weird reason.
Updated by mariussturm on 2015-11-25 13:06:01 +00:00
rest is fine, just a minor typo :) daniilyar@208e0ad#diff-db284b572b8d58fd607830d73594f479R143
Updated by daniilyar on 2015-11-26 22:12:02 +00:00
aww, here is why our patched Icinga logs 'invalid perfdata' errors on behalf of OpenTsdbWriter which we don't use ) Fixed.
I've switched adding perfdata fields OFF by default, so folks who already use GelfWriter will only notice 3 new fields: 'latency', 'execution_time' and 'reachable'.
Is there any docs for GelfWriter module I can extend with new option?
Updated by mfriedrich on 2015-12-18 10:09:45 +00:00
I've renamed it to "enable_send_perfdata" to reflect its purpose, in a similar naming pattern as we use in the GraphiteWriter feature.
The attribute was missing in the 6-object-types.md table. When sending patches adding or changing things, please always add/update the documentation.