Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10069] IDO: check_source should not be a TEXT field #3364

Closed
icinga-migration opened this issue Sep 1, 2015 · 11 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Sep 1, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10069

Created by tgelf on 2015-09-01 12:42:14 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-06-17 09:25:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-11-11 08:46:53 +00:00 (in Redmine)

Icinga Version: 2.4.0
Backport?: Not yet backported
Include in Changelog: 1

TEXT fields are very expensive, no need for using such for check_source.

Changesets

2016-06-17 09:03:26 +00:00 by leeclemens 759818d

DB IDO: Make check_source a varchar(255) column

fixes #10069

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2016-06-17 09:23:30 +00:00 by mfriedrich 6a46706

DB IDO: Update schema version to 1.14.1

The least supported version is still 1.14.0
with the current changes.

refs #10069
refs #11967

2016-06-20 14:17:06 +00:00 by mfriedrich f610e56

DB IDO: Fix missing schema version update in {mysql,pgsql}.sql

refs #10069
refs #11967
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2015

Updated by mfriedrich on 2015-09-01 14:21:14 +00:00

  • Parent Id set to 10073
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2015

Updated by mfriedrich on 2015-09-04 09:21:57 +00:00

  • Status changed from New to Assigned
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2016

Updated by mfriedrich on 2016-01-23 11:47:40 +00:00

  • Status changed from Assigned to New
  • Assigned to deleted tgelf
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 2, 2016

Updated by leeclemens on 2016-02-02 00:34:47 +00:00

#67

Please note I named the schema/upgrade file to 2.4.2.sql and set the dbversion to 1.14.1. Should the dbversion get bumped two to match the bugfix version of the next icinga2?

I also do not readily have a Postgres server available to test, but syntax matches previous statements. If someone could please test the postgres schema and upgrade?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2016

Updated by mfriedrich on 2016-03-11 20:48:58 +00:00

  • Target Version set to 2.5.0

Hi,

Schema changes should only happen for major releases. Though I don't know about 1.14+ yet, I'll deal with that when there are more schema changes coming in. For now it should stick with 2.5.0.sql and 1.14.1.

Kind regards,
Michael

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2016

Updated by leeclemens on 2016-03-15 01:11:13 +00:00

Hi Michael,

Thank you for the explanation, it makes sense. I have updated the 'upgrade sql' file names and still use 1.14.1 as the version. Hopefully this helps avoid any potential for confusion during a later merge.

Thanks,
Lee

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2016

Updated by mfriedrich on 2016-06-16 08:25:46 +00:00

  • Target Version changed from 2.5.0 to 2.6.0

We'll wait for Eric's feedback on IDO changes.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2016

Updated by tgelf on 2016-06-16 09:02:55 +00:00

dnsmichi wrote:

We'll wait for Eric's feedback on IDO changes.

Please not, please do not postpone them again. Pick the obvious quick wins laying around since a very long time and apply them, together with indexes fitting new comment-handling queries that came around with Icinga 2.

Many of the related issues are very important and super easy to fix, mostly problem and solution are already explained.

Thanks,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2016

Updated by mfriedrich on 2016-06-16 11:11:41 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version changed from 2.6.0 to 2.5.0

Feedback from Eric - should be added to 2.5.0.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2016

Updated by leeclemens on 2016-06-17 09:25:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 759818d.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2016

Updated by mfriedrich on 2016-11-11 08:46:54 +00:00

  • Parent Id deleted 10073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.