Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #10069] IDO: check_source should not be a TEXT field #3364
This issue has been migrated from Redmine: https://dev.icinga.com/issues/10069
Created by tgelf on 2015-09-01 12:42:14 +00:00
TEXT fields are very expensive, no need for using such for check_source.
2016-06-17 09:03:26 +00:00 by leeclemens 759818d
2016-06-17 09:23:30 +00:00 by mfriedrich 6a46706
2016-06-20 14:17:06 +00:00 by mfriedrich f610e56
Updated by leeclemens on 2016-02-02 00:34:47 +00:00
Please note I named the schema/upgrade file to 2.4.2.sql and set the dbversion to 1.14.1. Should the dbversion get bumped two to match the bugfix version of the next icinga2?
I also do not readily have a Postgres server available to test, but syntax matches previous statements. If someone could please test the postgres schema and upgrade?
Updated by mfriedrich on 2016-03-11 20:48:58 +00:00
Schema changes should only happen for major releases. Though I don't know about 1.14+ yet, I'll deal with that when there are more schema changes coming in. For now it should stick with 2.5.0.sql and 1.14.1.
Updated by leeclemens on 2016-03-15 01:11:13 +00:00
Thank you for the explanation, it makes sense. I have updated the 'upgrade sql' file names and still use 1.14.1 as the version. Hopefully this helps avoid any potential for confusion during a later merge.
Updated by tgelf on 2016-06-16 09:02:55 +00:00
Please not, please do not postpone them again. Pick the obvious quick wins laying around since a very long time and apply them, together with indexes fitting new comment-handling queries that came around with Icinga 2.
Many of the related issues are very important and super easy to fix, mostly problem and solution are already explained.