[dev.icinga.com #10069] IDO: check_source should not be a TEXT field #3364
Comments
Updated by mfriedrich on 2015-09-01 14:21:14 +00:00
|
Updated by mfriedrich on 2015-09-04 09:21:57 +00:00
|
Updated by mfriedrich on 2016-01-23 11:47:40 +00:00
|
Updated by leeclemens on 2016-02-02 00:34:47 +00:00 Please note I named the schema/upgrade file to 2.4.2.sql and set the dbversion to 1.14.1. Should the dbversion get bumped two to match the bugfix version of the next icinga2? I also do not readily have a Postgres server available to test, but syntax matches previous statements. If someone could please test the postgres schema and upgrade? |
Updated by mfriedrich on 2016-03-11 20:48:58 +00:00
Hi, Schema changes should only happen for major releases. Though I don't know about 1.14+ yet, I'll deal with that when there are more schema changes coming in. For now it should stick with 2.5.0.sql and 1.14.1. Kind regards, |
Updated by leeclemens on 2016-03-15 01:11:13 +00:00 Hi Michael, Thank you for the explanation, it makes sense. I have updated the 'upgrade sql' file names and still use 1.14.1 as the version. Hopefully this helps avoid any potential for confusion during a later merge. Thanks, |
Updated by mfriedrich on 2016-06-16 08:25:46 +00:00
We'll wait for Eric's feedback on IDO changes. |
Updated by tgelf on 2016-06-16 09:02:55 +00:00 dnsmichi wrote:
Please not, please do not postpone them again. Pick the obvious quick wins laying around since a very long time and apply them, together with indexes fitting new comment-handling queries that came around with Icinga 2. Many of the related issues are very important and super easy to fix, mostly problem and solution are already explained. Thanks, |
Updated by mfriedrich on 2016-06-16 11:11:41 +00:00
Feedback from Eric - should be added to 2.5.0. |
Updated by leeclemens on 2016-06-17 09:25:04 +00:00
Applied in changeset 759818d. |
Updated by mfriedrich on 2016-11-11 08:46:54 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/10069
Created by tgelf on 2015-09-01 12:42:14 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2016-06-17 09:25:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-11-11 08:46:53 +00:00 (in Redmine)
TEXT fields are very expensive, no need for using such for check_source.
Changesets
2016-06-17 09:03:26 +00:00 by leeclemens 759818d
2016-06-17 09:23:30 +00:00 by mfriedrich 6a46706
2016-06-20 14:17:06 +00:00 by mfriedrich f610e56
The text was updated successfully, but these errors were encountered: