Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10093] Rather use unique SID when granting rights for folders in NSIS on Windows Client #3379

Closed
icinga-migration opened this issue Sep 4, 2015 · 4 comments
Labels
bug
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Sep 4, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10093

Created by Isotop7 on 2015-09-04 09:33:10 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2015-09-24 06:50:06 +00:00)
Target Version: 2.3.11
Last Update: 2015-09-25 12:46:22 +00:00 (in Redmine)

Icinga Version: 2.3.9
Backport?: Already backported
Include in Changelog: 1

When i install Icinga2 Client (Windows Version) on several machines (Win Server 2008/2008R2/2012R2), the Icinga2SetupAgent can't write to $INSTALLDIR/etc because NSIS uses a static Windows group localized in English to apply rights on.

Therefore I need to manually adjust rights from "\Administrators" to "\Administratoren" (german translation).

It would be easier to just use the SID of the admin group in the icacls command in NSIS.

My request just changes hardcoded "Administrators" to its corresponding SID.

It would be nice if my change would be accepted. Thanks.

git: #46

Changesets

2015-09-24 06:45:35 +00:00 by Isotop7 33c0c2f

Use SIDs for setting permissions on $INSTDIR

fixes #10093

2015-09-24 06:46:14 +00:00 by (unknown) 26b902d

Update AUTHORS

refs #10093

2015-09-25 12:45:06 +00:00 by Isotop7 08bfcaa

Use SIDs for setting permissions on $INSTDIR

fixes #10093

2015-09-25 12:45:19 +00:00 by (unknown) 0b4a176

Update AUTHORS

refs #10093
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 4, 2015

Updated by Isotop7 on 2015-09-04 09:48:41 +00:00

I edited the pull request to also use the SID for the network service.

Thanks!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 24, 2015

Updated by gbeutner on 2015-09-24 06:45:50 +00:00

  • Status changed from New to Assigned
  • Assigned to set to gbeutner
  • Target Version set to 2.4.0

You seem to have missed one:

set(CPACK_NSIS_EXTRA_INSTALL_COMMANDS "${CPACK_NSIS_EXTRA_INSTALL_COMMANDS}\nnsExec::Exec 'icacls \\\"$INSTDIR\\\" /grant NetworkService:(oi)(ci)m'")

Anyway, I've updated your patch and merged it into the master branch.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 24, 2015

Updated by Isotop7 on 2015-09-24 06:50:06 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset 33c0c2f.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Sep 25, 2015

Updated by mfriedrich on 2015-09-25 12:46:22 +00:00

  • Target Version changed from 2.4.0 to 2.3.11
  • Backport? changed from TBD to Yes

I did have look at that a while ago, and I consider this perfectly fine for a back port, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.