Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #10093] Rather use unique SID when granting rights for folders in NSIS on Windows Client #3379
This issue has been migrated from Redmine: https://dev.icinga.com/issues/10093
Created by Isotop7 on 2015-09-04 09:33:10 +00:00
When i install Icinga2 Client (Windows Version) on several machines (Win Server 2008/2008R2/2012R2), the Icinga2SetupAgent can't write to $INSTALLDIR/etc because NSIS uses a static Windows group localized in English to apply rights on.
Therefore I need to manually adjust rights from "\Administrators" to "\Administratoren" (german translation).
It would be easier to just use the SID of the admin group in the icacls command in NSIS.
My request just changes hardcoded "Administrators" to its corresponding SID.
It would be nice if my change would be accepted. Thanks.
2015-09-24 06:45:35 +00:00 by Isotop7 33c0c2f
2015-09-24 06:46:14 +00:00 by (unknown) 26b902d
2015-09-25 12:45:06 +00:00 by Isotop7 08bfcaa
2015-09-25 12:45:19 +00:00 by (unknown) 0b4a176
Updated by gbeutner on 2015-09-24 06:45:50 +00:00
You seem to have missed one:
Anyway, I've updated your patch and merged it into the master branch.