Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10254] Performance Data Labels including '=' will not be displayed correct #3460

Closed
icinga-migration opened this issue Sep 30, 2015 · 4 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Sep 30, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10254

Created by wrssin on 2015-09-30 13:57:23 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2015-10-13 07:43:49 +00:00)
Target Version: 2.3.11
Last Update: 2015-10-13 11:12:58 +00:00 (in Redmine)

Icinga Version: 2.3.10
Backport?: Already backported
Include in Changelog: 1

In PerformaceData the label-string contains '=' it would be split into multiple labels.
e.g.:
'/usr/bin/java -Djava.util.logging.config.file=/opt/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager' should be oner label with VALUE;WARN;CRIT;MIN;MAX
icinga split this into
label: '/usr/bin/java -Djava.util.logging.config.file'
label: '-Djava.util.logging.manager'

Changesets

2015-10-13 07:38:31 +00:00 by (unknown) e92b7be

Fix parsing performance data labels which contain '='

fixes #10254

2015-10-13 11:12:42 +00:00 by (unknown) d741ca6

Fix parsing performance data labels which contain '='

fixes #10254
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Oct 13, 2015

Updated by gbeutner on 2015-10-13 07:19:09 +00:00

  • Status changed from New to Assigned
  • Assigned to set to gbeutner
  • Target Version set to 2.4.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Oct 13, 2015

Updated by gbeutner on 2015-10-13 07:43:42 +00:00

Fixed in the master branch:

$ icinga2 console
Icinga (version: v2.3.0-644-g2484016)
<1> => v = parse_performance_data("'/usr/bin/java -Djava.util.logging.config.file=/opt/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager'=1.0")
null
<2> => v.label
"/usr/bin/java -Djava.util.logging.config.file=/opt/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager"
<3> => v.value
1.0
<4> => 
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Oct 13, 2015

Updated by Anonymous on 2015-10-13 07:43:49 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset e92b7be.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Oct 13, 2015

Updated by gbeutner on 2015-10-13 11:12:58 +00:00

  • Target Version changed from 2.4.0 to 2.3.11
  • Backport? changed from TBD to Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.