Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10624] Add application manifest for the Windows agent wizard #3658

Closed
icinga-migration opened this issue Nov 13, 2015 · 15 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Nov 13, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10624

Created by Anonymous on 2015-11-13 16:58:59 +00:00

Assignee: TheFlyingCorpse
Status: Resolved (closed on 2016-04-12 10:18:58 +00:00)
Target Version: 2.4.5
Last Update: 2016-04-20 08:15:50 +00:00 (in Redmine)

Icinga Version: 2.3.11
Backport?: Already backported
Include in Changelog: 1

Please include the .exe.config file in Icinga2 Setup for Windows so you only need to have .Net 4.x installed if you are on 2012 or newer, no need to install .Net 3.5 with this configuration file in place. This reduces complexity of installing Icinga2 on newer OS'es like 2012 R2 when you dont want to install the messy .Net 3.5 on all servers unnecessarily.

Filename: Icinga2SetupAgent.exe.config
Path: same output folder as Icinga2SetupAgent.exe

Changesets

2016-03-13 18:32:14 +00:00 by TheFlyingCorpse 1e794c7

Removed .Net 3.5 dependency from the icinga2 nuget package as it is superceded by .Net 4 which is a requirement for chocolatey.
Added Icinga2SetupAgent.exe.config to the package so either .Net 3.5 or 4.x works. refs #10624

2016-03-14 19:44:58 +00:00 by TheFlyingCorpse c9743e8

Add the Icinga2SetupAgent.exe.config to Windows installer.

refs #10624

2016-04-12 10:18:32 +00:00 by TheFlyingCorpse 6f6c133

Add the Icinga2SetupAgent.exe.config to Windows installer

fixes #10624

2016-04-20 08:09:34 +00:00 by TheFlyingCorpse b7ccce9

Add the Icinga2SetupAgent.exe.config to Windows installer

fixes #10624

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2015

Updated by gbeutner on 2015-11-14 05:15:22 +00:00

  • Category changed from Installation to Packages
  • Priority changed from High to Normal
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2015

Updated by mfriedrich on 2015-11-25 14:30:02 +00:00

  • Status changed from New to Assigned
  • Assigned to set to __

Send in a patch for review please :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2016

Updated by mfriedrich on 2016-02-24 21:56:49 +00:00

Any updates please :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2016

Updated by TheFlyingCorpse on 2016-03-13 22:15:57 +00:00

See git commit!

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2016

Updated by mfriedrich on 2016-03-14 07:57:44 +00:00

Icinga2SetupAgent.exe.config is missing as a file - or is that created dynamically?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2016

Updated by mfriedrich on 2016-03-14 07:58:44 +00:00

  • Assigned to set to TheFlyingCorpse
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2016

Updated by TheFlyingCorpse on 2016-03-14 17:11:21 +00:00

The .exe.config is created from the App.config on compile and is placed in the output directory, in this case the bin directory with the Icinga2SetupAgent.exe. The App.config is correct for the purpose here so the fix is simply to copy that to the directory that the content for the NSIS installer is based on. :-)

Would you like the 2 changes in the commit split up to separate tickets? One for this older issue and a new one for the .nuget change?

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2016

Updated by TheFlyingCorpse on 2016-03-14 19:54:55 +00:00

Updated to only include the original fix, namely the .exe.config change.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2016

Updated by gbeutner on 2016-03-15 08:31:37 +00:00

  • Assigned to changed from TheFlyingCorpse to jflach

Jean: Can you please test this? :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2016

Updated by gbeutner on 2016-03-15 08:32:18 +00:00

  • Blocks set to 11384
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2016

Updated by mfriedrich on 2016-04-07 09:44:45 +00:00

  • Target Version set to 2.5.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2016

Updated by mfriedrich on 2016-04-07 09:44:56 +00:00

  • Relates set to 8802
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2016

Updated by gbeutner on 2016-04-12 10:18:58 +00:00

  • Status changed from Assigned to Resolved
  • Assigned to changed from jflach to TheFlyingCorpse
  • Target Version changed from 2.5.0 to 2.4.5
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2016

Updated by gbeutner on 2016-04-20 06:32:56 +00:00

  • Subject changed from Missing .exe.config file in Icinga2 setup on Windows to Add application manifest for the Windows agent wizard
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2016

Updated by gbeutner on 2016-04-20 08:15:50 +00:00

  • Backport? changed from Not yet backported to Already backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.