Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10739] Crash on startup with incorrect directory permissions #3723

Closed
icinga-migration opened this issue Nov 27, 2015 · 10 comments
Closed
Labels
bug
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Nov 27, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10739

Created by pschoenfeld on 2015-11-27 13:48:43 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-12-08 14:29:10 +00:00)
Target Version: 2.4.2
Last Update: 2015-12-08 14:30:15 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Already backported
Include in Changelog: 1

When installing from source (at least when installling with a custom INSTALL_PREFIX) the permissions of the files installed by make install are not correct.
This results in a SIGABRT when trying to run icinga2.

Steps to reproduce:

  • build icinga with icinga as user and group
  • make
  • make install
  • /path/to/icinga2/sbin/icinga2 daemon

In my test it failed due to /opt/icinga2/var/cache/icinga2/ not being owned by the icinga user. Chowning that directory makes icinga2 continue (until the next permission problem if any).

Changesets

2015-12-08 14:12:13 +00:00 by mfriedrich 407a750

Fix crash on startup with incorrect directory permissions

fixes #10739

2015-12-08 14:28:51 +00:00 by mfriedrich 833e280

Fix crash on startup with incorrect directory permissions

fixes #10739

Relations:

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 27, 2015

Updated by mfriedrich on 2015-11-27 15:41:31 +00:00

There's an exception thrown on wrong permissions which is not caught and causes the application to abort. The error message is pretty ugly, that's basically something we should enhance.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 27, 2015

Updated by pschoenfeld on 2015-11-27 16:16:16 +00:00

dnsmichi wrote:

There's an exception thrown on wrong permissions which is not caught and causes the application to abort. The error message is pretty ugly, that's basically something we should enhance.

There is no error message at all. In the case described above only one message is printed at all and what follows is a SIGABRT.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 27, 2015

Updated by mfriedrich on 2015-11-27 17:57:01 +00:00

Well, that's what I'm taliking about. I do see that myself from time to time, but I don't care much as we generally support and promote package installations. The source installation got issues with setting proper permissions in the first place, there's a ticket somewhere to fix that. Low priority though.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 28, 2015

Updated by pschoenfeld on 2015-11-28 10:48:50 +00:00

dnsmichi wrote:

(...) but I don't care much as we generally support and promote package installations.

Uh. I think that's a fatal attitude. After all it's the software, which is obviously not handling environmental errors properly in the first place. What if permissions get screwed up in a real environment? What if a new such case is introduced and one of the package maintainers is missing that one? What if it were a similar problem but with more troublesome consequences?

So, while I agree that the buildsystem issues could be thought of as "low prio", I don't think that any issue in the software itself can be.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 28, 2015

Updated by mfriedrich on 2015-11-28 11:05:51 +00:00

  • Status changed from New to Feedback
  • Assigned to set to pschoenfeld

Then send a patch and help out, please.

Kind regards,
Michael

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 1, 2015

Updated by mfriedrich on 2015-12-01 19:52:41 +00:00

  • Status changed from Feedback to New
  • Assigned to deleted pschoenfeld
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 1, 2015

Updated by mfriedrich on 2015-12-01 19:52:57 +00:00

  • Duplicated set to 10761
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 14:11:23 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.4.2
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 14:29:10 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 407a750.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 14:30:15 +00:00

  • Subject changed from SIGABRT on startup with wrong permissions to Crash on startup with incorrect directory permissions
  • Backport? changed from Not yet backported to Already backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.