Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10745] ITL check command possibly mistyped variable names #3729

Closed
icinga-migration opened this issue Nov 28, 2015 · 4 comments
Closed
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Nov 28, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10745

Created by lesinigo on 2015-11-28 20:56:14 +00:00

Assignee: lesinigo
Status: Resolved (closed on 2015-11-30 07:29:04 +00:00)
Target Version: 2.4.2
Last Update: 2015-12-08 14:41:59 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Already backported
Include in Changelog: 1

The ipmi-sensor command in ITL has these two arguments, as far as I can tell the "_exclude" part of the variable name has been put on the wrong one:

                "-x" = {
                        value = "$ipmi_sensor_id$"
                        description = "Exclude sensor matching ipmi_sensor_id"
                }
                "-i" = {
                        value = "$ipmi_exclude_sensor_id$"
                        description = "Include sensor matching ipmi_sensor_id"
                }

Attachments

Changesets

2015-11-30 07:28:21 +00:00 by (unknown) 3a47448

ITL: fix ipmi-sensor variable names

fixes #10745

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>

2015-11-30 07:28:26 +00:00 by (unknown) a5ef3f3

Update AUTHORS

refs #10745

2015-12-08 14:41:25 +00:00 by (unknown) 4616a1c

ITL: fix ipmi-sensor variable names

fixes #10745

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>

2015-12-08 14:41:36 +00:00 by (unknown) f6ba7aa

Update AUTHORS

refs #10745
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 28, 2015

Updated by lesinigo on 2015-11-28 20:57:28 +00:00

  • File added 0001-ITL-fix-ipmi-sensor-variable-names.patch

the proposed patch swaps the two variable names

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 30, 2015

Updated by gbeutner on 2015-11-30 07:29:00 +00:00

  • Status changed from New to Assigned
  • Assigned to set to lesinigo
  • Target Version set to 2.5.0

Merged. Thanks. :)

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Nov 30, 2015

Updated by Anonymous on 2015-11-30 07:29:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 3a47448.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 14:41:59 +00:00

  • Target Version changed from 2.5.0 to 2.4.2
  • Backport? changed from Not yet backported to Already backported
@icinga-migration icinga-migration added this to the 2.4.2 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.