Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10777] Add check_iostat to ITL #3747

Closed
icinga-migration opened this issue Dec 5, 2015 · 7 comments
Closed

[dev.icinga.com #10777] Add check_iostat to ITL #3747

icinga-migration opened this issue Dec 5, 2015 · 7 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Dec 5, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10777

Created by twidhalm on 2015-12-05 19:43:47 +00:00

Assignee: jflach
Status: Resolved (closed on 2016-02-19 11:19:11 +00:00)
Target Version: 2.4.2
Last Update: 2016-02-23 10:24:37 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

Hi,

I'd like to see the check_iostat version patched by dnsmichi as part of the ITL. Attached is a patch to add it.

Please be nice, since this is my first contribution - I'm willing to improve if you tell me if I'm doing something wrong.

Cheers,
Thomas

Attachments

Changesets

2016-02-19 11:18:33 +00:00 by twidhalm b7d55fc

Add check_iostat to ITL

fixes #10777

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>

2016-02-22 07:05:23 +00:00 by (unknown) 781c34f

Update AUTHORS

refs #10777
refs #11132

2016-02-23 08:45:34 +00:00 by (unknown) ed9a7bb

Update AUTHORS

refs #10777
refs #11132

2016-02-23 08:47:28 +00:00 by twidhalm fd0aa4a

Add check_iostat to ITL

fixes #10777

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 7, 2015

Updated by gbeutner on 2015-12-07 07:05:18 +00:00

  • Status changed from New to Assigned
  • Assigned to set to twidhalm
  1. Your patch adds a new, unrelated file:

    diff --git a/0001-Add-check_iostat-to-ITL.patch b/0001-Add-check_iostat-to-ITL.patch
    new file mode 100644
    index 0000000..fbc3a29
    --- /dev/null
    +++ b/0001-Add-check_iostat-to-ITL.patch

  2. The documentation should mention the default values (if there are any).

  3. We're using tabs in the ITL files.

  4. It is unnecessary to put quotes around numbers.

  5. contrib plugins should use the PluginContribDir constant

  6. Wording: "The plugin ... is a plugin" seems kinda redundant (in the documentation)

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 7, 2015

Updated by twidhalm on 2015-12-07 10:28:00 +00:00

  • File added 0001-Add-check_iostat-to-ITL.patch

Here you are.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 11, 2016

Updated by gbeutner on 2016-01-11 10:20:28 +00:00

  • Assigned to changed from twidhalm to jflach
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 19, 2016

Updated by twidhalm on 2016-02-19 11:19:11 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset b7d55fc.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 19, 2016

Updated by jflach on 2016-02-19 11:19:35 +00:00

  • Target Version set to 2.5.0
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 09:58:21 +00:00

  • Backport? changed from Not yet backported to Already backported
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 10:24:37 +00:00

  • Target Version changed from 2.5.0 to 2.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.