Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10787] Add "-x" parameter in command definition for disk-windows CheckCommand #3754

Closed
icinga-migration opened this issue Dec 7, 2015 · 11 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Dec 7, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10787

Created by brainsht on 2015-12-07 15:21:48 +00:00

Assignee: jflach
Status: Resolved (closed on 2016-01-18 09:15:03 +00:00)
Target Version: 2.4.2
Last Update: 2016-02-23 09:58:22 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

Please add the "-x" parameter in the command definition of the disk-windows check for excluding drives from being checked.

For example:

@ "-x" = {
value = "$disk_win_exclude$"
description = "Exclude these drives from check"
}@

Attachments

Changesets

2016-01-18 09:12:58 +00:00 by brainsht 3e33ee0

Added exclude parameter in disk-windows CheckCommand

Added missing command parameter in definition for disk-windows CheckCommand
in order to be able to exclude certain drives from being checked.
This parameter was addressed in feature #9201
Further details can be found in feature #10787

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>

fixes #10787

2016-01-18 09:27:54 +00:00 by (unknown) 09cb793

Added exclude parameter in disk-windows CheckCommand

Added missing command parameter in definition for disk-windows CheckCommand
in order to be able to exclude certain drives from being checked.
This parameter was addressed in feature #9201
Further details can be found in feature #10787

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>

fixes #10787

2016-02-23 08:26:07 +00:00 by (unknown) 1c37f59

Added exclude parameter in disk-windows CheckCommand

Added missing command parameter in definition for disk-windows CheckCommand
in order to be able to exclude certain drives from being checked.
This parameter was addressed in feature #9201
Further details can be found in feature #10787

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>

fixes #10787
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 13:41:47 +00:00

  • Status changed from New to Feedback
  • Assigned to set to brainsht

Can you send in a patch including the ITL and documentation update? Thanks :)

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 9, 2015

Updated by brainsht on 2015-12-09 13:57:41 +00:00

  • File added command-plugins-windows.conf.patch

Okay I'll have a crack at it, but bear with me as I'm not a developer :)
The patchfile is attached (please let me know if something is wrong with it).

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 10, 2015

Updated by brainsht on 2015-12-10 10:17:11 +00:00

  • File added 7-icinga-template-library.md.patch
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 10, 2015

Updated by jflach on 2015-12-10 16:16:55 +00:00

Hey, thanks for your patches!
But please use git formatted patches so you can be listed as a contributor.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 10, 2015

Updated by brainsht on 2015-12-10 17:16:27 +00:00

  • File added 0001-Added-exclude-parameter-in-disk-windows-CheckCommand.patch

I just read the developer guidelines... My bad.
Anyway here's the git formatted patch :)

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 11, 2016

Updated by gbeutner on 2016-01-11 10:37:52 +00:00

  • Status changed from Feedback to Assigned
  • Assigned to changed from brainsht to jflach
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 18, 2016

Updated by jflach on 2016-01-18 09:07:10 +00:00

  • Target Version set to 2.5.0
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 18, 2016

Updated by brainsht on 2016-01-18 09:15:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 3e33ee0.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 18, 2016

Updated by jflach on 2016-01-18 09:23:23 +00:00

  • Done % changed from 100 to 0

I applied your patch just now.

There will also be commit that changes your name in the authors file from 'brainsht' to 'Eduard Güldner' since we have a real name policy for commits.
If this is not your name, or you want some different name to be in the AUTHORS file please open a new ticket and I will see to it.

Kind regards,
Jean

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 25, 2016

Updated by mfriedrich on 2016-01-25 10:39:46 +00:00

  • Target Version changed from 2.5.0 to 2.4.2
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 09:58:22 +00:00

  • Backport? changed from Not yet backported to Already backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.