Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10795] http check's URI is really just Path #3755

Closed
icinga-migration opened this issue Dec 8, 2015 · 9 comments
Closed

[dev.icinga.com #10795] http check's URI is really just Path #3755

icinga-migration opened this issue Dec 8, 2015 · 9 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Dec 8, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10795

Created by pas on 2015-12-08 12:48:03 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-02-24 21:15:03 +00:00)
Target Version: 2.4.4
Last Update: 2016-03-11 14:50:37 +00:00 (in Redmine)

Icinga Version: 2.4.2
Backport?: Already backported
Include in Changelog: 1

Hello!

This is a really annoying bug report about semantics, sorry for that; it took a couple minutes of strace and almost some tcpdump to figure out that check_http's -u wants the path of the resource, not the URI. But the docs are not much help there.

https://github.com/Icinga/icinga2/blob/master/itl/command-plugins.conf#L329

http://docs.icinga.org/icinga2/latest/search?q=http\_uri\#!/icinga2/latest/doc/module/icinga2/chapter/plugin-check-commands?highlight-search=http#plugin-check-command-http

Maybe sometime in the future with a spring cleaning this variable could be renamed.

Thanks.

Changesets

2016-02-24 21:13:03 +00:00 by mfriedrich dcc9772

Docs: http check's URI is really just Path

fixes #10795

2016-03-11 14:50:29 +00:00 by mfriedrich aadbe98

Docs: http check's URI is really just Path

fixes #10795
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 12:54:37 +00:00

That's pretty much the parameter is called in the check_http documentation: https://www.monitoring-plugins.org/doc/man/check\_http.html

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by pas on 2015-12-08 13:35:36 +00:00

Yes, which is misleading too :), and anyone using just check_http will at least find the `--url=PATH default: / ` part of their documentation, which is much more helpful, than the "the request URI" explanation from the icinga docs.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2015

Updated by mfriedrich on 2015-12-08 13:40:11 +00:00

  • Category set to Documentation
  • Status changed from New to Feedback
  • Assigned to set to pas

Send a patch please :)

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Dec 10, 2015

Updated by gbeutner on 2015-12-10 08:43:51 +00:00

We should probably update the documentation to explain how this parameter works, e.g. by adding an example.

pas: Can you provide a patch for this please?

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 24, 2016

Updated by mfriedrich on 2016-02-24 21:12:52 +00:00

  • Status changed from Feedback to Assigned
  • Assigned to changed from pas to mfriedrich
  • Target Version set to 2.4.4

I guess that was a "no".

I've pushed a simple fix to git master.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 24, 2016

Updated by mfriedrich on 2016-02-24 21:15:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset dcc9772.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by pas on 2016-03-04 13:22:20 +00:00

Sorry, I did not meant to be rude, however, I had no idea how to clone-fork-edit-commit-attackpull your sources and I thought even just making a simple .patch file and submitting it, and you reviewing it and so on, would take more time. (And then I forgot even to reply, oops.)

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 13:26:52 +00:00

We should probably make this more clear, and add it directly to the website. Meanwhile you can check out https://wiki.icinga.org/display/community/Update+the+Icinga+2+documentation

Kind regards,
Michael

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 11, 2016

Updated by mfriedrich on 2016-03-11 14:50:37 +00:00

  • Backport? changed from Not yet backported to Already backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.