Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10956] Compiler warnings in lib/remote/base64.cpp #3832

Closed
icinga-migration opened this issue Jan 12, 2016 · 7 comments
Closed
Labels
bug
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jan 12, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10956

Created by gbeutner on 2016-01-12 06:55:15 +00:00

Assignee: jflach
Status: Resolved (closed on 2016-01-18 08:45:03 +00:00)
Target Version: 2.4.2
Last Update: 2016-02-23 10:54:24 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Already backported
Include in Changelog: 1

[117/386] Building CXX object lib/remote/CMakeFiles/remote.dir/base64.cpp.o
../lib/remote/base64.cpp:35:2: warning: expression result unused [-Wunused-value]
 (int)BIO_ctrl(bio64,11,0,__null);
 ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/remote/base64.cpp:57:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
 while (rc = BIO_read(bio64, outbuf + len, input.GetLength() - len))
        ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/remote/base64.cpp:57:12: note: place parentheses around the assignment to silence this warning
 while (rc = BIO_read(bio64, outbuf + len, input.GetLength() - len))
           ^
        (                                                          )
../lib/remote/base64.cpp:57:12: note: use '==' to turn this assignment into an equality comparison
 while (rc = BIO_read(bio64, outbuf + len, input.GetLength() - len))
           ^
           ==
2 warnings generated.

Changesets

2016-01-12 10:02:32 +00:00 by jflach cd9cb47

Fix compiler warning

fixes #10956

2016-01-13 07:33:27 +00:00 by (unknown) de11ef7

Fix compiler warning

fixes #10956

2016-01-18 08:41:52 +00:00 by jflach 08698c3

Fix another compiler warning

fixes #10956

2016-02-23 09:54:34 +00:00 by (unknown) 8798c34

Fix compiler warning

fixes #10956

2016-02-23 09:54:34 +00:00 by jflach debdace

Fix another compiler warning

fixes #10956
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 12, 2016

Updated by jflach on 2016-01-12 14:25:03 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset cd9cb47.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 12, 2016

Updated by jflach on 2016-01-12 15:20:35 +00:00

  • Target Version set to 2.5.0
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 18, 2016

Updated by gbeutner on 2016-01-18 07:03:37 +00:00

  • Status changed from Resolved to Assigned

With cb70d97 I still get this warning:

../lib/remote/base64.cpp:35:2: warning: expression result unused [-Wunused-value]
 (int)BIO_ctrl(bio64,11,0,__null);
 ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[25/25] Install the project...
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 18, 2016

Updated by jflach on 2016-01-18 08:45:03 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset 08698c3.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 09:54:03 +00:00

  • Target Version changed from 2.5.0 to 2.4.2
  • Icinga Version changed from 2 to 2
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 09:58:39 +00:00

  • Backport? changed from Not yet backported to Already backported
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 10:54:24 +00:00

  • Subject changed from Compiler warnings to Compiler warnings in lib/remote/base64.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.