Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #10974] Modified attributes do not work for the IcingaApplication object w/ external commands #3843
This issue has been migrated from Redmine: https://dev.icinga.com/issues/10974
Created by ziesemer on 2016-01-15 05:57:20 +00:00
The global system states (Active/Passive Checks Enabled, Notifications Enabled, etc.) no longer remain persistent after a restart or reload in Icinga 2, as they did in Icinga 1.
Per-host and per-service states are persisting as expected, but not the global options.
2016-01-21 18:07:54 +00:00 by mfriedrich 730db0c
2016-02-23 08:23:25 +00:00 by mfriedrich ec9caa4
Updated by mfriedrich on 2016-01-21 18:07:46 +00:00
Most likely resulting from the change in #9859.
Values are correctly set (disabled host checks)
Values are not stored in the state file:
(which is perfectly fine, as we now have modified-attributes.conf. Though this is not written.)
The culprit is the way the external commands set the values - they need to call ModifyAttribute() on the Icingaapplication config object instead of directly modifying the Icingaapplication values.
We did not encounter that problem when implementing and testing the API actions since we moved that task to modifying the Icingaapplicakion object instead.
Thanks for catching this! :)
Updated by ziesemer on 2016-01-21 19:07:16 +00:00
I'm happy to report, and thanks for the quick fix!
Similarly, would you maybe be able to take a quick pass at #10912 ? (From what I'm seeing, it looks like it was maybe just an incomplete commit that never should have hit the release?)