Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11014] Check event duplication with parallel connections involved #3866

Closed
icinga-migration opened this issue Jan 22, 2016 · 12 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Jan 22, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11014

Created by tgelf on 2016-01-22 14:49:34 +00:00

Assignee: gbeutner
Status: Closed (closed on 2016-01-26 13:39:43 +00:00)
Target Version: 2.4.2
Last Update: 2016-02-23 09:58:44 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Already backported
Include in Changelog: 1

The only way to run a safe environment when there are Icinga agents involved is to allow endpoint connections in only one directions, otherwise you'll get a mix of checks being executed twice the very same time, and eventually those check results being duplicated once again when sent upstream. Even more duplication takes place in case there are older connection threads hanging around for whatever reason. Or when multiple masters are involved - I found no way to work around that scenario.

Farther details have been shipped in a customer support issue, please feel free to ask in case additional information is required.

Cheers,
Thomas

Changesets

2016-01-25 09:57:06 +00:00 by (unknown) 8f53835

Make sure we only have one connection per satellite

refs #11014

2016-01-25 13:25:37 +00:00 by mfriedrich 055b261

Fix cluster config sync timestamp

refs #11014

2016-01-25 13:39:21 +00:00 by mfriedrich a17419e

Fix cluster config sync timestamp

refs #11014

2016-01-25 14:21:25 +00:00 by mfriedrich f1cb5af

Fix cluster config timestamp again

refs #11014

2016-01-25 14:49:32 +00:00 by mfriedrich d412a90

Fix cluster config timestamp again

refs #11014

2016-01-26 08:04:26 +00:00 by (unknown) 980ce96

Make sure the .timestamp file is synced for config updates

refs #11014

2016-01-26 09:46:27 +00:00 by (unknown) f3351bc

Make sure the updated config sync works with old versions of Icinga 2

refs #11014

2016-01-26 10:32:54 +00:00 by (unknown) c5a003c

Ignore the .timestamp file when determining whether the zone config has changed

refs #11014

2016-01-26 14:46:03 +00:00 by (unknown) 4185c75

Ignore the .timestamp file when determining whether the zone config has changed (second attempt)

refs #11014

2016-01-27 07:43:20 +00:00 by (unknown) 9ae1f1a

Improve performance for ApiListener::SyncRelayMessage

refs #11014

2016-01-27 11:18:16 +00:00 by (unknown) 8c05003

Improve the performance for ApiListener::SyncRelayMessage (part 2)

refs #11014

2016-01-27 12:39:31 +00:00 by (unknown) 54df0b7

Improve performance for ApiListener::RelayMessageOne

refs #11014

2016-01-27 14:45:58 +00:00 by (unknown) 9689223

Use multiple WorkQueues to process cluster messages

refs #11014

2016-01-27 15:43:23 +00:00 by (unknown) 5fb7bda

Decode cluster messages in the WorkQueue threads

refs #11014

2016-01-27 15:52:01 +00:00 by (unknown) fa7d044

Decode cluster messages in the WorkQueue threads

refs #11014

2016-01-28 06:19:32 +00:00 by (unknown) 9a1b5f9

Avoid updating the file descriptor list for poll() unless we really need to

refs #11014

2016-01-28 07:24:33 +00:00 by (unknown) 3c76e70

Avoid updating the file descriptor list for poll() unless we really need to

refs #11014

2016-01-28 07:48:48 +00:00 by (unknown) 1f17b3d

Avoid unnecessary wake-ups in SocketEvents::ChangeEvents

refs #11014

2016-01-28 08:05:49 +00:00 by (unknown) 75f7fe1

Avoid unnecessary wake-ups in SocketEvents::ChangeEvents

refs #11014

2016-01-28 10:55:31 +00:00 by (unknown) 4237c6e

Avoid unnecessary wake-ups in SocketEvents::ChangeEvents (part 2)

refs #11014

2016-01-28 11:23:07 +00:00 by (unknown) fe421d7

Remove debug output

refs #11014

2016-01-28 12:07:09 +00:00 by (unknown) 56e7c24

Avoid unnecessary dictionary lookups in SocketEvents::ThreadProc

refs #11014

2016-01-28 12:09:17 +00:00 by (unknown) 6fc91a3

Avoid unnecessary reallocs in FIFO::Optimize

refs #11014

2016-01-28 13:52:55 +00:00 by (unknown) 7f914d9

Add instrumentation macros to SocketEvents::ThreadProc

refs #11014

2016-01-29 13:03:58 +00:00 by mfriedrich 7a3848a

Remove debug output

refs #11014

2016-01-29 13:09:50 +00:00 by mfriedrich c2cf614

Remove debug output, part 2

refs #11014

2016-02-01 07:35:55 +00:00 by (unknown) deac316

Fix deadlock in {HttpServerConnection,JsonRpcConnection}::DataAvailableHandler

refs #11014

2016-02-01 08:33:33 +00:00 by (unknown) c03e458

Avoid unnecessary new/deletes

refs #11014

2016-02-01 10:25:34 +00:00 by (unknown) 98e104a

Fix incorrect method call in JsonRpcConnection::MessageHandler

refs #11014

2016-02-01 11:58:42 +00:00 by (unknown) e6a972f

Fix incorrect memcpy() with overlapping buffers

refs #11014

2016-02-01 13:50:18 +00:00 by (unknown) ec050dd

Fix deadlock in HttpClientConnection::DataAvailableHandler

refs #11014

2016-02-02 07:28:54 +00:00 by (unknown) 83889dc

Increase the buffer size in TlsStream::OnEvent to avoid unnecessary poll() calls

refs #11014

2016-02-02 08:52:23 +00:00 by (unknown) ecfaf01

Avoid unnecessary pollfd updates

refs #11014

2016-02-02 08:54:31 +00:00 by (unknown) 3f95e86

Remove debug log message

refs #11014

2016-02-02 10:17:33 +00:00 by (unknown) 532655d

Use multiple threads for socket IO

refs #11014

2016-02-02 11:03:12 +00:00 by (unknown) f234bdd

Fix crash in IdoCheckTask::ScriptFunc

refs #11014

2016-02-02 12:51:17 +00:00 by (unknown) fabf37e

Improve performance for TlsStream::OnEvent

refs #11014

2016-02-04 15:01:19 +00:00 by (unknown) b324446

Implement support for epoll

refs #11014

2016-02-04 15:31:59 +00:00 by (unknown) 611ff86

Implement support for epoll

refs #11014

2016-02-16 12:30:55 +00:00 by (unknown) 9a8458f

Rename the IOTHREADS macro

refs #11014

2016-02-23 08:31:51 +00:00 by (unknown) fbc638e

Make sure we only have one connection per satellite

refs #11014

2016-02-23 08:31:51 +00:00 by mfriedrich f7df3be

Fix cluster config sync timestamp

refs #11014

2016-02-23 08:31:51 +00:00 by mfriedrich 8859242

Fix cluster config timestamp again

refs #11014

2016-02-23 08:31:51 +00:00 by (unknown) c6be1c9

Make sure the .timestamp file is synced for config updates

refs #11014

2016-02-23 08:31:51 +00:00 by (unknown) b7a152e

Make sure the updated config sync works with old versions of Icinga 2

refs #11014

2016-02-23 08:31:51 +00:00 by (unknown) 12b5e33

Ignore the .timestamp file when determining whether the zone config has changed

refs #11014

2016-02-23 08:31:51 +00:00 by (unknown) e7a1c83

Ignore the .timestamp file when determining whether the zone config has changed (second attempt)

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) 0d5592a

Improve performance for ApiListener::SyncRelayMessage

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) f9efc2f

Improve the performance for ApiListener::SyncRelayMessage (part 2)

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) 864cdee

Improve performance for ApiListener::RelayMessageOne

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) d1b7056

Use multiple WorkQueues to process cluster messages

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) 85c962a

Decode cluster messages in the WorkQueue threads

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) 77abfed

Avoid updating the file descriptor list for poll() unless we really need to

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) 579d004

Avoid unnecessary wake-ups in SocketEvents::ChangeEvents (part 2)

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) d474877

Remove debug output

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) 211fc5a

Avoid unnecessary dictionary lookups in SocketEvents::ThreadProc

refs #11014

2016-02-23 08:31:52 +00:00 by (unknown) fe79c54

Avoid unnecessary reallocs in FIFO::Optimize

refs #11014

2016-02-23 08:31:52 +00:00 by mfriedrich 186b520

Remove debug output

refs #11014

2016-02-23 08:31:52 +00:00 by mfriedrich a49f8f1

Remove debug output, part 2

refs #11014

2016-02-23 08:32:36 +00:00 by (unknown) 55720f3

Fix deadlock in {HttpServerConnection,JsonRpcConnection}::DataAvailableHandler

refs #11014

2016-02-23 08:32:37 +00:00 by (unknown) f3ab63b

Avoid unnecessary new/deletes

refs #11014

2016-02-23 08:32:38 +00:00 by (unknown) 4ae0681

Fix incorrect method call in JsonRpcConnection::MessageHandler

refs #11014

2016-02-23 08:32:38 +00:00 by (unknown) 4565a1f

Fix incorrect memcpy() with overlapping buffers

refs #11014

2016-02-23 08:32:38 +00:00 by (unknown) 60181e0

Fix deadlock in HttpClientConnection::DataAvailableHandler

refs #11014

2016-02-23 08:32:38 +00:00 by (unknown) 0fbbe62

Increase the buffer size in TlsStream::OnEvent to avoid unnecessary poll() calls

refs #11014

2016-02-23 08:33:01 +00:00 by (unknown) d36c3d4

Avoid unnecessary pollfd updates

refs #11014

2016-02-23 08:33:02 +00:00 by (unknown) 4fdc704

Remove debug log message

refs #11014

2016-02-23 08:33:45 +00:00 by (unknown) 1fe27e5

Use multiple threads for socket IO

refs #11014

2016-02-23 08:33:47 +00:00 by (unknown) 3b4fc69

Fix crash in IdoCheckTask::ScriptFunc

refs #11014

2016-02-23 08:34:20 +00:00 by (unknown) a2cbe1a

Improve performance for TlsStream::OnEvent

refs #11014

2016-02-23 08:51:47 +00:00 by (unknown) 9313373

Rename the IOTHREADS macro

refs #11014

2016-02-23 09:49:24 +00:00 by (unknown) 87817bf

Implement support for epoll

refs #11014

Relations:

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 22, 2016

Updated by tgelf on 2016-01-22 14:50:09 +00:00

  • Subject changed from Check event duplicates with multiple involved connections to Check event duplication with parallel connections involved
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 22, 2016

Updated by mfriedrich on 2016-01-22 15:12:53 +00:00

  • Target Version set to 2.5.0
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 22, 2016

Updated by tgelf on 2016-01-22 20:22:49 +00:00

  • Relates set to 10758
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 25, 2016

Updated by mfriedrich on 2016-01-25 09:38:49 +00:00

  • Priority changed from Normal to Urgent
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 25, 2016

Updated by mfriedrich on 2016-01-25 10:26:31 +00:00

  • Target Version changed from 2.5.0 to 2.4.2
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 26, 2016

Updated by gbeutner on 2016-01-26 13:39:43 +00:00

  • Status changed from New to Closed
  • Assigned to set to gbeutner

This should be fixed in the master branch.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Jan 29, 2016

Updated by mfriedrich on 2016-01-29 09:23:44 +00:00

  • Relates set to 11041
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 1, 2016

Updated by mfriedrich on 2016-02-01 13:06:28 +00:00

  • Relates set to 11060
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 3, 2016

Updated by mfriedrich on 2016-02-03 13:42:10 +00:00

  • Relates set to 10991
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 4, 2016

Updated by mfriedrich on 2016-02-04 12:12:27 +00:00

  • Relates deleted 10758
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 4, 2016

Updated by mfriedrich on 2016-02-04 12:13:05 +00:00

  • Duplicated set to 10758
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 23, 2016

Updated by gbeutner on 2016-02-23 09:58:44 +00:00

  • Backport? changed from Not yet backported to Already backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.