Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #11112] Empty author/text attribute for comment/downtimes external commands causing crash #3912
This issue has been migrated from Redmine: https://dev.icinga.com/issues/11112
Created by PowellEB on 2016-02-08 17:25:12 +00:00
We have external scripts that update comments for services.
The scripts did not include an author when adding the COMMENT.
Under 2.3.11, this did not cause a problem.
Now on 2.4.1 (02/06/2016), as soon as one of these ADD_SVC_COMMENT/ADD_HOST_COMMENT is processed, icinga2 core process dies.
We have updated our scripts to include an author, and icinga2 core has not crashed anymore.
2016-04-25 14:58:00 +00:00 by jflach 360e0ad
2016-05-11 14:12:09 +00:00 by mfriedrich 3c85231
2016-05-12 09:08:20 +00:00 by jflach 0e70165
2016-05-12 09:11:03 +00:00 by mfriedrich a6e70a1
Updated by mfriedrich on 2016-05-11 14:11:57 +00:00
The real problem is hidden in AddComment and AddDowntime, so in addition to fixing the external command listener, we'll also need to ensure that calling AddComment itself does not crash on a null pointer.