Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11112] Empty author/text attribute for comment/downtimes external commands causing crash #3912

Closed
icinga-migration opened this issue Feb 8, 2016 · 10 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Feb 8, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11112

Created by PowellEB on 2016-02-08 17:25:12 +00:00

Assignee: jflach
Status: Resolved (closed on 2016-04-25 15:00:07 +00:00)
Target Version: 2.4.8
Last Update: 2016-05-30 08:26:21 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Not yet backported
Include in Changelog: 1

We have external scripts that update comments for services.
[1454949940] ADD_SVC_COMMENT;somehost;someservice;0;;https://......

The scripts did not include an author when adding the COMMENT.

Under 2.3.11, this did not cause a problem.

Now on 2.4.1 (02/06/2016), as soon as one of these ADD_SVC_COMMENT/ADD_HOST_COMMENT is processed, icinga2 core process dies.

We have updated our scripts to include an author, and icinga2 core has not crashed anymore.

b/r,
Eric

Changesets

2016-04-25 14:58:00 +00:00 by jflach 360e0ad

Fix external commands comments crashing icinga

Now an exception will be thrown when AddSvcComment or AddHostComment are
run with and empty Author or comment

fixes #11112

2016-05-11 14:12:09 +00:00 by mfriedrich 3c85231

Fix possible crash in Add{Comment,Downtime}

refs #11112

2016-05-12 09:08:20 +00:00 by jflach 0e70165

Fix external commands comments crashing icinga

Now an exception will be thrown when AddSvcComment or AddHostComment are
run with and empty Author or comment

fixes #11112

2016-05-12 09:11:03 +00:00 by mfriedrich a6e70a1

Fix possible crash in Add{Comment,Downtime}

refs #11112

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2016

Updated by mfrosch on 2016-02-09 19:02:19 +00:00

Please move this issue to icinga2.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2016

Updated by mfriedrich on 2016-02-10 10:48:35 +00:00

  • Project changed from Icinga Web 2 to Icinga 2
  • Category set to Compat
  • Icinga Version set to 2
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 17:11:01 +00:00

  • Relates set to 11242
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2016

Updated by mfriedrich on 2016-03-18 13:53:36 +00:00

  • Status changed from New to Assigned
  • Assigned to set to jflach
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2016

Updated by jflach on 2016-04-25 15:00:07 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 360e0ad.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2016

Updated by jflach on 2016-04-25 15:01:40 +00:00

  • Target Version set to 2.4.8
  • Backport? changed from __ to Not yet backported
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 11, 2016

Updated by mfriedrich on 2016-05-11 14:11:57 +00:00

  • Subject changed from empty attribute "author", [ADD_HOST_COMMENT, ADD_SVC_COMMENT] crash icinga2 to Empty author/text attribute for comment/downtimes external commands causing crash

The real problem is hidden in AddComment and AddDowntime, so in addition to fixing the external command listener, we'll also need to ensure that calling AddComment itself does not crash on a null pointer.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 11, 2016

Updated by mfriedrich on 2016-05-11 14:15:31 +00:00

  • Include in Changelog changed from __ to 1
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 26, 2016

Updated by PowellEB on 2016-05-26 03:43:14 +00:00

Just a heads up.

we are still on 2.4.7-1, and just had a crash.

author="" but it was from ACKNOWLEDGE_SVC_PROBLEM_EXPIRE, ACKNOWLEDGE_SVC_PROBLEM.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 30, 2016

Updated by jflach on 2016-05-30 08:26:21 +00:00

@powelleb

Please update to 2.4.8, which contains the patch for this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.