Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11141] tm_hour = 24 not valid according to manuals #3930

Closed
icinga-migration opened this issue Feb 11, 2016 · 5 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Feb 11, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11141

Created by gvde on 2016-02-11 12:50:17 +00:00

Assignee: (none)
Status: Rejected (closed on 2016-05-11 06:49:44 +00:00)
Target Version: (none)
Last Update: 2016-08-08 11:14:24 +00:00 (in Redmine)

Icinga Version: master/2.4.1
Backport?: Not yet backported
Include in Changelog: 1

According to the manual pages for the struct tm and other places tm_hour is 0-23. Thus even though settings it to 24 may work as intended at this time there is no guarantee for the future.

Found at least twice in root/lib/icinga/legacytimeperiod.cpp and maybe elsewhere, too.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2016

Updated by atj on 2016-02-11 15:41:46 +00:00

See #11147 for additional examples of this.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 16:47:54 +00:00

  • Parent Id set to 11310
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 3, 2016

Updated by mfriedrich on 2016-05-03 13:35:00 +00:00

  • Status changed from New to Assigned
  • Assigned to set to jflach
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented May 11, 2016

Updated by gbeutner on 2016-05-11 06:49:45 +00:00

  • Status changed from Assigned to Rejected
  • Assigned to deleted jflach

The mktime(3) manpage seems to suggest that this is in fact supported:

The mktime() function modifies the fields of the tm structure as follows: tm_wday and tm_yday are set to values determined from the contents of the other fields;
if structure members are outside their valid interval, they will be normalized (so that, for example, 40 October is changed into 9 November); tm_isdst is set (regardless
of its initial value) to a positive value or to 0, respectively, to indicate whether DST is or is not in effect at the specified time. Calling mktime() also sets the external
variable tzname with information about the current timezone.
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2016

Updated by mfriedrich on 2016-08-08 11:14:25 +00:00

  • Parent Id deleted 11310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.