Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11257] Incorrect check interval when passive check results are used #3987

Closed
icinga-migration opened this issue Feb 29, 2016 · 13 comments
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Feb 29, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11257

Created by de1m on 2016-02-29 08:41:38 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-03-11 08:35:29 +00:00)
Target Version: 2.4.4
Last Update: 2016-03-24 09:37:52 +00:00 (in Redmine)

Icinga Version: r2.4.3-1
Backport?: Already backported
Include in Changelog: 1

Hi all,
my config for service checks:

template Service "passive-service" {
        max_check_attempts = 2
        check_interval          = 300s
        #retry_interval          = 300s
        enable_active_checks = true
        enable_passive_checks = true
        check_command = "passive"
        #vars.notification["mail"] = {
        #groups = [ "icingaadmins" ]
        #}

}

in command icingg2 object list:

Object 'docker1-hosting' of type 'Host':
  % declared in '/icinga2conf/docker1-hosting.conf', lines 1:0-1:28
  * __name = "docker1-hosting"
  * action_url = ""
  * address = ""
  * address6 = ""
  * check_command = "passive"
    % = modified in '/icinga2conf/passive.conf', lines 20:9-20:33
  * check_interval = 300
    % = modified in '/icinga2conf/passive.conf', lines 16:9-16:38
  * check_period = ""
  * command_endpoint = ""
  * display_name = "Docker1 Hosting VM"
    % = modified in '/icinga2conf/docker1-hosting.conf', lines 3:2-3:37
  * enable_active_checks = true
    % = modified in '/icinga2conf/passive.conf', lines 18:2-18:28
  * enable_event_handler = true
  * enable_flapping = false
  * enable_notifications = true
  * enable_passive_checks = true
    % = modified in '/icinga2conf/passive.conf', lines 19:9-19:36
  * enable_perfdata = true
  * event_command = ""
  * flapping_threshold = 30
  * groups = [ ]
  * icon_image = ""
  * icon_image_alt = ""
  * max_check_attempts = 2
    % = modified in '/icinga2conf/passive.conf', lines 15:2-15:23
  * name = "docker1-hosting"
  * notes = ""
  * notes_url = ""
  * package = "_etc"
  * retry_interval = 60
  * templates = [ "docker1-hosting", "passive-host" ]
    % = modified in '/icinga2conf/docker1-hosting.conf', lines 1:0-1:28
    % = modified in '/icinga2conf/passive.conf', lines 14:1-14:28
  * type = "Host"
  * vars
    * group = "adito"
      % = modified in '/icinga2conf/docker1-hosting.conf', lines 4:2-4:22
  * volatile = false
  * zone = ""

My problem is now, that my passive checks not working now.

The active_check "passive" run each 60 sec. and set my service and hosts to state unavailable

Changesets

2016-03-05 17:15:03 +00:00 by mfriedrich b8e3d61

Revert "Properly set the next check time for active and passive checks"

This reverts commit 2a11b27972e4325bf80e9abc9017eab7dd03e712.

This patch does not properly work and breaks the check_interval setting
for passive checks. Requires a proper patch.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287

2016-03-05 17:16:49 +00:00 by mfriedrich ef532f2

Revert "Fix check scheduling w/ retry_interval"

This reverts commit a51e647cc760bd5f7c4de6182961a477478c11a9.

This patch causes trouble with check results received
1) passively 2) throughout the cluster. A proper patch
for setting the retry_interval on NOT-OK state changes
is required.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287

2016-03-11 14:55:03 +00:00 by mfriedrich 8344f74

Revert "Properly set the next check time for active and passive checks"

This reverts commit 2a11b27972e4325bf80e9abc9017eab7dd03e712.

This patch does not properly work and breaks the check_interval setting
for passive checks. Requires a proper patch.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287

2016-03-11 14:55:14 +00:00 by mfriedrich f99feab

Revert "Fix check scheduling w/ retry_interval"

This reverts commit a51e647cc760bd5f7c4de6182961a477478c11a9.

This patch causes trouble with check results received
1) passively 2) throughout the cluster. A proper patch
for setting the retry_interval on NOT-OK state changes
is required.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 29, 2016

Updated by mfriedrich on 2016-02-29 09:00:09 +00:00

  • Relates set to 11248
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Feb 29, 2016

Updated by mfriedrich on 2016-02-29 10:10:45 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 15:27:26 +00:00

  • Relates set to 11273
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 15:31:42 +00:00

  • Relates deleted 11273
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 15:33:11 +00:00

  • Relates deleted 11248
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 15:33:20 +00:00

  • Parent Id set to 11310
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 4, 2016

Updated by mfriedrich on 2016-03-04 15:55:21 +00:00

  • Category changed from Configuration to libicinga
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 5, 2016

Updated by mfriedrich on 2016-03-05 17:40:10 +00:00

I've reverted 2 commits which might be causing trouble here. Can you please re-test the current git master?

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 9, 2016

Updated by mfriedrich on 2016-03-09 10:43:49 +00:00

  • Priority changed from Normal to High
  • Target Version set to 2.4.4

The reverts restore the old behaviour known from 2.4.1 and should therefore fix the problem. It'll be great if you could test them in order to include them into the next bugfix release. Thanks.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 11, 2016

Updated by mfriedrich on 2016-03-11 08:35:29 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

I consider this being fixed.

@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 11, 2016

Updated by mfriedrich on 2016-03-11 14:55:39 +00:00

  • Backport? changed from Not yet backported to Already backported
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 15, 2016

Updated by gbeutner on 2016-03-15 13:39:37 +00:00

  • Subject changed from If retry_interval is not define, then this will be set automaticaly to 60s. Passive check not working now. to Incorrect check interval when passive check results are used
@icinga-migration
Copy link
Member Author

@icinga-migration icinga-migration commented Mar 24, 2016

Updated by mfriedrich on 2016-03-24 09:37:52 +00:00

  • Parent Id deleted 11310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.