Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[dev.icinga.com #11419] Config parser should not log names of included files by default #4046
This issue has been migrated from Redmine: https://dev.icinga.com/issues/11419
Created by tgelf on 2016-03-19 22:28:23 +00:00
Problem: "information/ConfigCompiler: Compiling config file: ..." lines make up more than half a megabyte of data at each restart. And I didn't even add those nasty "warning/ConfigObject: Ignoring config object ... due to errors" lines to that number.
We should either find a more efficient way to store that kind of data (read: one single file for all of them) or get rid of those log lines.
2016-07-05 13:43:48 +00:00 by mfriedrich 915ebe1
Updated by tgelf on 2016-03-21 08:18:51 +00:00
I'm perfectly aware of #10717, but please re-evaluate this issue. It targets another problem, I'm talking about systems running with hundreds or even thousands valid and non-expired comments or downtimes. Erroneous ones like those in #10717 make it worse, but this problem wouldn't change once that is fixed.
Updated by mfriedrich on 2016-03-21 19:46:28 +00:00
Discussed it offline. The problem is with a lot of comment/downtime objects put into separate files, causing a long list of 'compiling file' entries. Though that's the default output of the config compiler - it might be a discussion point to filter that away somehow for the API packages startup.log file.
Updated by tgelf on 2016-03-21 20:00:22 +00:00
if it was only for the API I wouldn't care. I could perfectly filter away that noise before storing to the Director DB. But such massive log outputs might influence a lot of other components:
We probably do not know where all this data is going to finish. To me that's a good reason to generate as less noise as possible. Several thousand lines for a reload seems a little bit too much to me. This way the related (startup) log data written to disk is larger than the real comment/downtime payload.
Updated by mfriedrich on 2016-07-05 13:38:35 +00:00
One thing which feels much more comfortable - hide loading libraries and including each file into the "notice" log level. Adding an additional "loading config files" log entry to let the user know when it starts. With the change in #12098 you'll only have certain warnings for unreadable files, but won't have to visually grep between "Information" and "Warning".
Updated by tgelf on 2016-07-05 14:03:16 +00:00
@dnsmichi: I know that you are used to modify subjects to obtain a good-looking changelog, allowing you to benefit from the "Include in Changelog" flag.
However, please consider opening a dedicated ticket for that purpose when modifying the subject of a user-generated issue to something completely different than initially requested. When someone doesn't get what he wants that's something he has to live with. But when history overview suggests that he has been in some way responsible for a change he didn't ask for, he could remain ... well ... not amused.