Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12225] Icinga stats min_execution_time and max_execution_time are invalid #4399

Closed
icinga-migration opened this issue Jul 25, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Jul 25, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12225

Created by TheFlyingCorpse on 2016-07-25 15:26:22 +00:00

Assignee: TheFlyingCorpse
Status: Resolved (closed on 2016-07-26 08:00:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-07-26 08:00:04 +00:00 (in Redmine)

Icinga Version: 2.4.10
Backport?: Not yet backported
Include in Changelog: 1

The data is copied from latency to execution_time for min/max, thus causing it to be invalid.

Files:
https://git.icinga.org/?p=icinga2.git;a=blob;f=lib/icinga/cib.cpp;hb=ce3d7ab973e319283f3aa3fd8f610e90b293d565;js=1
https://git.icinga.org/?p=icinga2.git;a=blob;f=lib/methods/icingachecktask.cpp;hb=ce3d7ab973e319283f3aa3fd8f610e90b293d565;js=1

Found while debugging #12216

Patch linked in a sec.

Changesets

2016-07-25 15:28:24 +00:00 by TheFlyingCorpse db5db8f

Fix min/max execution_time

refs #12225

2016-07-26 07:56:21 +00:00 by TheFlyingCorpse 54eb954

Fix min/max execution_time

fixes #12225

Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2016

Updated by gbeutner on 2016-07-26 07:56:52 +00:00

  • Status changed from New to Assigned
  • Target Version set to 2.5.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2016

Updated by TheFlyingCorpse on 2016-07-26 08:00:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 54eb954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.