Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12256] Add check command definition for check_graphite #4416

Closed
icinga-migration opened this issue Jul 29, 2016 · 8 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Jul 29, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12256

Created by mwaldmueller on 2016-07-29 09:31:58 +00:00

Assignee: mwaldmueller
Status: Resolved (closed on 2016-07-29 09:42:14 +00:00)
Target Version: 2.5.0
Last Update: 2016-08-29 16:05:12 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

Add Plugin Check Command for check_graphite

Attachments

Changesets

2016-07-29 09:38:57 +00:00 by mwaldmueller 6d082e6

Add check command definition for check_graphite

fixes #12256

Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2016

Updated by gbeutner on 2016-07-29 09:34:46 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mwaldmueller
  • Target Version set to 2.5.0

ITL commands in the plugins-contrib.d directory should use the PluginContribDir variable. :)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2016

Updated by mwaldmueller on 2016-07-29 09:40:45 +00:00

  • File added 0001-Add-Plugin-Check-Command-for-check_graphite.patch

Thanks for your hint ;-)

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2016

Updated by mwaldmueller on 2016-07-29 09:42:14 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 6d082e6.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2016

Updated by mwaldmueller on 2016-07-29 10:12:44 +00:00

  • File added 0001-Updated-documentation-for-graphite.patch

Sorry, once again...

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2016

Updated by gbeutner on 2016-08-22 11:58:02 +00:00

  • Subject changed from Add Plugin Check Command for check_graphite to Add check command definition for check_graphite
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2016

Updated by cmh on 2016-08-26 12:09:46 +00:00

Saw this showed up in latest update of Icinga2 and it uses the obfuscurity check_graphite script. That script hasn't been updated in over a year and depends on Ruby which leads to all types of dependency hell in CentOS 6 due to the ancient version of Ruby available from the default repos. I didn't feel like installing a newer version of Ruby just so I could run one plugin command.

Because of that, I had defined the "graphite" checkcommand to use Etsy's version, (https://github.com/etsy/nagios\_tools) which is far more neglected (last updated 2 years ago) and not perfect (https://github.com/etsy/nagios\_tools/pull/10) but it runs fine with the python that ships with CentOS 6.

I've evaluated about 8 different check_graphite scripts from github, and none are perfect, but several offer features which might make them a better choice over the obfuscurity plugin, depending on the user's needs.

With this in the latest update, my icinga setup broke because of the conflict between my "graphite" CheckCommand and this one. While I can rename mine to avoid the conflict, making the decision that everyone would want to use the obfuscurity plugin might not be the best course of action.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2016

Updated by mfriedrich on 2016-08-29 13:26:19 +00:00

It has been sitting in "plugins-contrib" for a while now - similar to "mem" which might break existing installations too. The only notable change (which is emphasised on in the Changelog file as well as the release blog post notes) is the inclusion of that part of the template library for new installations by default. If you decide that you don't want to use the contributed plugin check command definitions, disable the default inclusion.

In either way, you have to make a decision which plugin is the default for a CheckCommand definition. One will hate you for that, one will love your for that. I trust the expertise of Markus choosing the right one. If you've got a better idea about CheckCommand object naming / versioning for specific plugins with the same name, please let us know (best by opening a new issue for future discussion).

Kind regards,
Michael

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2016

Updated by cmh on 2016-08-29 16:05:12 +00:00

Yep, I renamed mine to avoid the conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.