Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12288] Change the way outdated comments/downtimes are deleted on restart #4425

Closed
icinga-migration opened this issue Aug 2, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Aug 2, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12288

Created by mfriedrich on 2016-08-02 12:38:05 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-08-02 12:40:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-08-02 12:40:04 +00:00 (in Redmine)

Icinga Version: 2.5.0
Backport?: Not yet backported
Include in Changelog: 1

OnConfigUpdate() - DELETE by object_id for comments, downtimes tables and INSERT afterwards is worse than UPDATE, INSERT and and overall DELETE once the config dump is completed. There are additional events fired when the downtime expires or manually gets canceled which are independent from the config dump.

Changesets

2016-08-02 12:37:16 +00:00 by mfriedrich cd5c936

DB IDO: Use upsert and session token for comment/downtime updates

refs #12258
fixes #12288

2016-08-02 13:05:21 +00:00 by mfriedrich 1ff6939

Fix missing MySQL session_token changes

refs #12258
refs #12288

2016-08-03 14:15:22 +00:00 by mfriedrich 00f05a8

DB IDO: Do not try to delete downtimes when using the session_token

Missed it after modifying the comments.

refs #12258
refs #12288

2016-08-11 15:43:39 +00:00 by mfriedrich d84872f

DB IDO: Really do not clear downtimes on checkable upsert

refs #12258
refs #12288

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2016

Updated by mfriedrich on 2016-08-02 12:40:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset cd5c936.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2016

Updated by mfriedrich on 2016-08-02 12:40:04 +00:00

  • Relates set to 12258
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2016

Updated by mfriedrich on 2016-08-02 12:40:23 +00:00

  • Relates set to 11688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.