Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12454] API: action schedule-downtime requires a duration also when fixed is true #4496

Closed
icinga-migration opened this issue Aug 16, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Aug 16, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12454

Created by dgoetz on 2016-08-16 13:47:37 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-08-16 15:10:00 +00:00)
Target Version: 2.5.0
Last Update: 2016-08-16 15:10:00 +00:00 (in Redmine)

Icinga Version: v2.4.10
Backport?: Not yet backported
Include in Changelog: 1

The action schedule-downtime requires a duration also when fixed is true, but fixed downtimes should only require start_time and end_time.
Documentation tells correctly that it is required but it is not very intuitive to require a field not necessary.

Changesets

2016-08-16 15:09:25 +00:00 by mfriedrich 520be95

API: Fix that schedule-downtime action requires duration for fixed=true

fixes #12454
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2016

Updated by mfriedrich on 2016-08-16 15:08:24 +00:00

  • Status changed from New to Assigned

  • Assigned to set to mfriedrich

  • Target Version set to 2.5.0

    $ curl -k -s -u root:icinga -H 'Accept: application/json' -X POST 'https://localhost:5665/v1/actions/schedule-downtime' -d '{ "filter": true, "type": "Service", "author": "michi", "comment": "test", "start_time": 1471359988, "end_time": 1471360088, "fixed": false }'
    {"results":[{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"},{"code":404.0,"status":"Option 'duration' is required for flexible downtime"}]}

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2016

Updated by mfriedrich on 2016-08-16 15:10:00 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 520be95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.