New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullptr dereferences #6104
Fix nullptr dereferences #6104
Conversation
|
I have no idea why commit c508d74 is in there :/ |
|
Wrong rebase base, I'd suggest to start with a fresh master and cherry-pick on-top into a new branch. |
lib/base/object.hpp
Outdated
| @@ -57,6 +57,10 @@ extern Value Empty; | |||
| DECLARE_PTR_TYPEDEFS(klass); \ | |||
| IMPL_TYPE_LOOKUP(); | |||
|
|
|||
| #define RequireNotNull(ptr) RequireNotNullInternal(ptr, #ptr) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Macros should be capitalised throughout, so REQUIRE_NOT_NULL would be correct, wouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-o-X ^
|
When merging back into the master the files relevant to the commit are not touched. Sometimes git works in mysterious ways |
This is used to fix a number of possible nullptr dereferences
7b1d9ed
to
a71ab1e
Compare
This prevents a number of nullptr dereferences within icinga 2.
Refs CVE-2018-6534