Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Acknowledgment notifications should only be send if problem notification has been send #6527
I needed to draw the differences and changes between versions. The patch also involves a change with Recovery notifications, this should be highlighted in a separate issue (for the changelog).
Need to simplify the patch for the problem filter, test it again, and then write upgrading docs.
@N-o-X the patch with
I've constructed a test case for this, please always include test protocols and configs in theses PRs :)
I'm simulating a timeperiod where at first start, the problem notification is not sent to this specific user. Later, before the acknowledgement happens, I'm stopping Icinga 2, disabling the timeperiod and starting Icinga 2 again.
Verify the logs.
Use the above configuration, but add more users with recovery details.
This is easy, same procedure as above, except for sending an UP check result instead of an Acknowledgement.