New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that no_more_notifications gets reset when Recovery notifications are filtered away #6757

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@dnsmichi
Member

dnsmichi commented Nov 8, 2018

Hello from the OSMC hackathon :)

Description

Combination of notification interval = 0, times.begin = 1h and filtered recovery notificadtions.

The problem arises with the first critical/down notification which delays the notification to 3h hours in the future, and sets no_more_notifications to true.

Once a recovery notification is triggered, this does not reach the point where it actually evaluates users to notify. It also does not reset no_more_notifications to false again, allowing our NOTOK-OK-NOTOK state transition logic to kick in.

We've analysed the problem with @jschanz and created a possible fix for it. A workaround for the problem is to add the Recovery type again to the notification objects and send a dummy OK check results to also reset the no_more_notifications flag to false again.

img_2461
img_2462
img_2463
img_2464

Fix that no_more_notifications gets reset when Recovery notifications…
… are filtered away

Hello from the OSMC hackathon :)
@jschanz

This comment has been minimized.

Contributor

jschanz commented Nov 8, 2018

auswahl_043
auswahl_044
auswahl_045

@dnsmichi dnsmichi added this to the 2.11.0 milestone Nov 13, 2018

@dnsmichi

This comment has been minimized.

Member

dnsmichi commented Nov 13, 2018

Since there's a workaround for now, I'd like to see the fix being tested a bit more before backporting it to 2.10. Therefore scheduling for 2.11 or 2.10.x later.

@dnsmichi dnsmichi merged commit 26f4116 into master Dec 5, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dnsmichi dnsmichi deleted the bugfix/no-more-notifications-recovery-filtered branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment