Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double whitespaces for notifications log message #7192

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@Crited
Copy link
Member

commented May 22, 2019

Add space to checkable debug message to unify timestamp format:

Behavior before: Update checkable 'c2-mysql-2!ping4' with check interval '60' from last check time at 2019-05-22 14:17:52 +0200 (1.55853e+09) to next check time at 2019-05-22 14:18:49 +0200(1.55853e+09).
Expected behavior: Update checkable 'c2-mysql-2!ping4' with check interval '60' from last check time at 2019-05-22 14:17:52 +0200 (1.55853e+09) to next check time at 2019-05-22 14:18:49 +0200 (1.55853e+09).

Remove double whitespaces for notifications log message.

Behavior before: Attempting to send  notifications for notification object 'icinga2.1.vagrant.demo.icinga.com!random-001!mail-icingaadmin'.
Expected behavior: Attempting to send notifications for notification object 'icinga2.1.vagrant.demo.icinga.com!random-001!mail-icingaadmin'.

Yet, I am not sure if this is the best way of solving this problem.

Remove double whitespaces for notifications log message
Add space to checkable debug message to unify timestamp format

@dnsmichi dnsmichi requested a review from htriem May 23, 2019

@dnsmichi dnsmichi added the area/log label May 23, 2019

@dnsmichi

This comment has been minimized.

Copy link
Member

commented May 23, 2019

@htriem Please have a look.

@htriem

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

I've applied and tested the commit.

[2019-06-19 16:20:06 +0200] notice/Notification: Attempting to send notifications for notification object 'Machtriem.local!mail-icingaadmin'.
[2019-06-19 16:20:07 +0200] debug/Checkable: Update checkable 'henrik' with check interval '1' from last check time at 2019-06-19 16:20:06 +0200 (1.56095e+09) to next check time at 2019-06-19 16:20:08 +0200 (1.56095e+09).

Everything appears to be in working order, and the log output is looking like we want it to. Nice work, @Crited! 👍

@htriem
htriem approved these changes Jun 19, 2019

@dnsmichi dnsmichi added this to the 2.11.0 milestone Jun 19, 2019

@dnsmichi dnsmichi added the bug label Jun 19, 2019

@htriem htriem merged commit 0381be3 into Icinga:master Jun 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.