Match api permissions against joined relations #9561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
approved these changes
Oct 31, 2022
krishnacx
reviewed
Nov 1, 2022
| /** | ||
| * Checks whether the given API user is granted the given permission | ||
| * | ||
| * When you desire an exception to be raised when the given user doesn't have the given permission, |
There was a problem hiding this comment.
given is redundant since it is already mentioned in the line above.
There was a problem hiding this comment.
I think the description should be before CheckPermission body
icinga-probot
bot
deleted the
match-api-permissions-against-join-relations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9408