Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with imported nodes that are empty #270

Closed
raviks789 opened this issue Feb 26, 2020 · 0 comments · Fixed by #272
Closed

Problems with imported nodes that are empty #270

raviks789 opened this issue Feb 26, 2020 · 0 comments · Fixed by #272
Labels
bug Something isn't working
Milestone

Comments

@raviks789
Copy link
Contributor

raviks789 commented Feb 26, 2020

Describe the bug

If an imported node is empty or if it is deleted at a later time then there is a problem with
sourceURL(). This results in an exception 'Trying to access a missing business process node <$name>'.

To Reproduce

Empty Node

  1. create a new business process with some name (Test).
  2. add an empty node to this business process (Test-process).
  3. create one more business process (Test1).
  4. add a node to this process by importing business process Test.

Deleted Node

  1. create a new business process with some name (Test).
  2. add an empty node to this business process (Test-process).
  3. create one more business process (Test1).
  4. add a node to this process by importing business process Test.
  5. delete the node Test-process in the business process Test.

Your Environment

icingaweb2 - 2.6.3-1.stretch, icingaweb2-module-businessprocess 2.1.0.

raviks789 added a commit that referenced this issue Feb 26, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Feb 26, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Feb 26, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Feb 26, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Feb 27, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Feb 28, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Feb 28, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Mar 10, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
raviks789 added a commit that referenced this issue Mar 10, 2020
If the imported node is empty or was deleted at a later time, then in NodeTile::render() $link should not be rendered. Also, NodeTile::addDetailsAction() should not add a `href` to this tile.

fixes: #270
@lippserd lippserd added this to the 2.3.0 milestone May 11, 2020
@lippserd lippserd added the bug Something isn't working label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants