Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grapher hook #172

Closed
wants to merge 0 commits into from
Closed

Add grapher hook #172

wants to merge 0 commits into from

Conversation

matthenning
Copy link
Contributor

This pull requests adds a grapher hook to display the business process in the service view of services using the icingacli-businessprocess command.

You can switch from tile to tree rendering mode by setting the icingacli_businessprocess_grapher_tree service variable to true.

Please let me know if there are things that need to be changed.

Examples:

Tile:
grafik

Tree:
grafik

@matthenning
Copy link
Contributor Author

Do you have feedback for this? :)
I'd be happy to modify what's necessary to bring this to a mergable state.

@lippserd
Copy link
Member

Hi,

Thanks for the PR. We'll look at this one asap.

Cheers,
Eric

@nilmerg
Copy link
Member

nilmerg commented Feb 19, 2019

Hi,

sorry that this has been forgotten. I had a quick look at it just now.

Though, your master is currently way too old. It can't be merged into our master in this state. Please fix this and rebase with our current master. You'll then see that the hook is not functional anymore due to incompatibilities.

If you don't know how to perform the rebase properly, here are steps:

Revert the recent merge first, it doesn't destroy anything and cleans up your history

git reset --hard HEAD^

Then perform an interactive rebase with our master (The reference to our master is probably invalid, you'll need to adjust this)

git rebase -i Icinga/icingaweb2-module-businessprocess:master

An editor pops up, adjust the displayed content from this

pick 25ec1dd Added Grapher
pick b946400 Provide grapher hook
pick c05d346 Fixed CI errors
pick a6a0ac9 Fixed line breaks
pick 6e48dba Added missing semicolon
pick 5521c61 added docblocks, made sure to catch all Exceptions

to this

pick 25ec1dd Added Grapher
f c05d346 Fixed CI errors
f a6a0ac9 Fixed line breaks
f 6e48dba Added missing semicolon
f 5521c61 added docblocks, made sure to catch all Exceptions
pick b946400 Provide grapher hook

Save. If everything went well, you've two commits left, based on our current master

commit dc5ce832bbce473d379e5591ec4f424633d54ec0 (HEAD -> matthenning-master)
Author: Matthias pub@matthias-henning.de
Date: Fri Jun 15 11:36:55 2018 +0200

Provide grapher hook

commit 253a40c4d39627f388a3ffc1012224de392ccedf
Author: Matthias pub@matthias-henning.de
Date: Fri Jun 15 11:35:38 2018 +0200

Added Grapher

You can now make the hook work again. Please report back once you're done. If I don't hear anything from you for a month, I'll close the pull request.

Thanks.

@lippserd
Copy link
Member

Plus, this must be a DetailViewExtensionHook. You may only have one graph in a detail area but multiple extensions.

@matthenning
Copy link
Contributor Author

Thank you for your feedback.
I'll look into it as soon as I can allocate some time for it.

@nilmerg nilmerg added enhancement New feature or improvement needs-feedback We'll only proceed once we hear from you again labels May 10, 2019
@nilmerg
Copy link
Member

nilmerg commented Apr 21, 2021

Can we still expect an update?

@nilmerg nilmerg closed this Jul 19, 2022
@cla-bot cla-bot bot added the cla/signed label Jul 19, 2022
@nilmerg
Copy link
Member

nilmerg commented Jul 19, 2022

Github decided to close this for some reason... Superseded by #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or improvement needs-feedback We'll only proceed once we hear from you again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants