Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long headers #35

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@theFeu
Copy link
Contributor

commented Jul 8, 2019

fixes #30

@theFeu theFeu requested a review from lippserd Jul 8, 2019

text-align: center;
color: white;
margin-bottom: 1em;

> a:first-child {
flex: 1;

This comment has been minimized.

Copy link
@lippserd

lippserd Jul 11, 2019

Member

Using display: block; here is sufficient and does not require flex.

This comment has been minimized.

Copy link
@theFeu

theFeu Jul 11, 2019

Author Contributor

The flex here is to properly align the filter icon to the right while maintaining a set width to truncate on :)

This comment has been minimized.

Copy link
@lippserd

lippserd Jul 11, 2019

Member

Check. Makes sense. But it must also work for cube-dimension1.

This comment has been minimized.

Copy link
@theFeu

theFeu Jul 11, 2019

Author Contributor

.cube-dimension-1 doesn't need this, because it's nothing more than a headline with no content and there is nothing that gets pushed down - so i think it would make more sense to allow longer headings there.

This comment has been minimized.

Copy link
@lippserd

lippserd Jul 11, 2019

Member

Please configure more than one dimension 😉

@theFeu theFeu added this to the 1.1.0 milestone Jul 11, 2019

@theFeu theFeu self-assigned this Jul 11, 2019

@theFeu theFeu force-pushed the feature/truncate-long-headers-30 branch from 7aa078c to 4d63f64 Jul 12, 2019

@theFeu theFeu requested a review from lippserd Jul 12, 2019

@lippserd lippserd merged commit cb2d7b3 into master Jul 12, 2019

@lippserd lippserd deleted the feature/truncate-long-headers-30 branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.