Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10683] lib/CLI command web serve: rename variable basedir to something meaningful #2159

Closed
icinga-migration opened this issue Nov 19, 2015 · 5 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Nov 19, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10683

Created by aklimov on 2015-11-19 17:47:29 +00:00

Assignee: (none)
Status: Resolved (closed on 2015-11-20 17:45:04 +00:00)
Target Version: 2.1.1
Last Update: 2015-12-10 12:26:12 +00:00 (in Redmine)


As a user I have no idea what a "basedir" is. I could think it's the source root dir (/vagrant) or similar.
My suggestion: wwwroot

Changesets

2015-11-20 17:05:42 +00:00 by aklimov 1515430

WebCommand::serveAction(): rename parameter $basedir to $documentRoot

resolves #10683
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 20, 2015

Updated by elippmann on 2015-11-20 08:50:31 +00:00

  • Assigned to deleted tgelf
  • Target Version set to Backlog

Just for the records. we're using --root or --document-root in the config command.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 20, 2015

Updated by elippmann on 2015-11-20 08:51:24 +00:00

  • Tracker changed from Bug to Feature
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 20, 2015

Updated by aklimov on 2015-11-20 17:45:04 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 1515430.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 23, 2015

Updated by elippmann on 2015-11-23 08:26:55 +00:00

  • Subject changed from CLI command web serve: rename parameter basedir to something meaningful to CLI command web serve: rename variable basedir to something meaningful
  • Target Version changed from Backlog to 273
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 10, 2015

Updated by elippmann on 2015-12-10 12:26:12 +00:00

  • Tracker changed from Feature to Bug
  • Subject changed from CLI command web serve: rename variable basedir to something meaningful to lib/CLI command web serve: rename variable basedir to something meaningful
  • Target Version changed from 273 to 2.1.1
@icinga-migration icinga-migration added this to the 2.1.1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.