Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10884] Tabs MUST throw an exception when activating an inexistant tab #2213

Closed
icinga-migration opened this issue Dec 17, 2015 · 1 comment
Labels
bug
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Dec 17, 2015

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10884

Created by tgelf on 2015-12-17 22:17:28 +00:00

Assignee: (none)
Status: Resolved (closed on 2015-12-21 09:10:04 +00:00)
Target Version: 2.1.1
Last Update: 2015-12-21 09:10:04 +00:00 (in Redmine)


One of the original intentions of the activate() method was to obtain a lightweight component allowing to restrict access to specific tasks. In case a specific tab has not been defined "a priori" any attempt to activate it should result in a failure, preferably 404. This allows to avoid redundant ACL checks in many occasions.

Expected behaviour is that the following MUST throw an exception:

$this->getTabs()->activate('this-does-not-exist');

Current behaviour: nothing happens.

Cheers,
Thomas

Changesets

2015-12-21 09:09:13 +00:00 by elippmann a3f89c8

lib/Tabs: Throw HttpNotFoundException when activating an inexistent tab

refs #10884

2015-12-21 09:09:40 +00:00 by elippmann 8ba7b41

Merge branch 'bugfix/exception-on-activating-inexistent-tab-10884'

fixes #10884
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 21, 2015

Updated by elippmann on 2015-12-21 09:10:04 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 8ba7b41.

@icinga-migration icinga-migration added this to the 2.1.1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.