Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11032] Fix icon_image size and provide a CSS class for theming #2253

Closed
icinga-migration opened this issue Jan 26, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Jan 26, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11032

Created by ziesemer on 2016-01-26 07:17:19 +00:00

Assignee: (none)
Status: Resolved (closed on 2016-02-27 21:50:04 +00:00)
Target Version: 2.2.0
Last Update: 2016-02-27 21:50:04 +00:00 (in Redmine)


https://dev.icinga.org/issues/8665 provided for supporting icon_image in Icinga Web 2. However, it appears that IW2 makes to attempts to resize the supplied icons - even by just adding the appropriate HTML attributes to have the browser resize the icon without growing parent elements on the page.

This continues to work as expected in the Classic UI, which allows for "larger" images to be supplied as source, which can appear larger on the information pages - but in the "Host / Service Detail" pages, they are rendered with height="20" width="20".

The same should happen in IW2, or configurable values should be allowed, or admins should be able to easily and properly manage custom CSS that would be able to accommodate this. (See also https://lists.icinga.org/pipermail/icinga-users/2015-June/009731.html, which supports the latter part of this request.) For now, I simply hacked /usr/share/icingaweb2/public/css/icinga/main.less to include img.icon{width:20px;height:20px} - but this isn't exactly maintainable. Even just providing a "custom.less" file that would be read by the library and generated into the resulting "icinga.main.css" could be helpful here.

Changesets

2016-02-27 20:57:02 +00:00 by elippmann dc0359f

Fix icon_image size and provide a CSS class for theming

fixes #11032
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2016

Updated by elippmann on 2016-02-18 15:34:24 +00:00

  • Subject changed from Fix icon_image size, and/or provide for CSS hooks. to Fix icon_image size and provide a CSS class for theming
  • Category changed from UI to Monitoring
  • Target Version set to 2.2.0

Hi,

Thanks for the report. Will be fixed in our next release.

Best,
Eric

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2016

Updated by elippmann on 2016-02-27 21:50:04 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset dc0359f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.