Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11100] Comments are always persistent #2280

Closed
icinga-migration opened this issue Feb 5, 2016 · 5 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Feb 5, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11100

Created by ClemensBW on 2016-02-05 18:34:26 +00:00

Assignee: (none)
Status: Resolved (closed on 2016-02-27 21:50:06 +00:00)
Target Version: 2.2.0
Last Update: 2016-02-27 21:50:06 +00:00 (in Redmine)


Hello,

if I create a new comment for a host, it is always persistent.

Version: 2.1.2
Git Commit: ce705e5

Attachments

Changesets

2016-02-25 16:45:51 +00:00 by elippmann 47b3019

Add MonitoringBackend::isIcinga2()

This function is for the many places where we have to distinguish between Icinga 1.x and Icinga 2.x.

refs #11100

2016-02-25 16:51:02 +00:00 by elippmann 02eea2a

Disable persistent comment checkbox if backend is Icinga 2

refs #11100

2016-02-27 21:48:45 +00:00 by elippmann 70d296e

Merge branch 'bugfix/disable-comment-persisent-for-icinga2-11100'

fixes #11100
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2016

Updated by elippmann on 2016-02-18 10:02:31 +00:00

  • Project changed from Icinga Web 2 to Icinga 2
  • Subject changed from comments are alltimes persistent to Comments are always persistent
  • Category deleted Monitoring
  • Priority changed from Normal to High
  • (unknown custom field) set to 2

Steps to reproduce:

  • Add a non-persistent comment
  • Notice that IDO and Web 2 reflects that it is persistent though
  • Restart Icinga 2
  • Comment still exists
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2016

Updated by elippmann on 2016-02-18 10:05:22 +00:00

  • Priority changed from High to Normal
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2016

Updated by gbeutner on 2016-02-18 10:32:46 +00:00

  • Project changed from Icinga 2 to Icinga Web 2

Icinga 2 does not currently support non-persistent comments, sorry. :)

Ideally Web 2 shouldn't display the "persistent" checkbox when using Icinga 2.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2016

Updated by elippmann on 2016-02-18 11:33:15 +00:00

  • Category set to Monitoring
  • Target Version set to 2.2.0
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2016

Updated by elippmann on 2016-02-27 21:50:06 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 70d296e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.