Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #11143] Layout: Tabs should be left-aligned #2291

Closed
icinga-migration opened this issue Feb 11, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

commented Feb 11, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/11143

Created by tgelf on 2016-02-11 13:15:48 +00:00

Assignee: elippmann
Status: Resolved (closed on 2016-02-22 08:30:08 +00:00)
Target Version: 2.2.0
Last Update: 2016-02-24 10:52:15 +00:00 (in Redmine)


They where aligned to the menu, right now they form kind of a stair.

Cheers,
Thomas

Changesets

2016-02-20 14:12:40 +00:00 by tgelf f9a10bc

layout: no left/right margin for tabs

refs #11143

2016-02-22 08:26:53 +00:00 by elippmann 17d0f7b

CSS: Avoid !important for gutter in .controls

fixes #11143
@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2016

Updated by tgelf on 2016-02-21 08:17:03 +00:00

  • Status changed from Assigned to Feedback

Hi Eric,

this was because of the gutter, I committed a fix for the tabs. I'd however prefer to not see !important expect where it is absolutely possible. Could you please try to find out whether we need it here?

Thanks,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2016

Updated by elippmann on 2016-02-22 08:30:08 +00:00

  • Status changed from Feedback to Resolved
  • Done % changed from 0 to 100

Applied in changeset 17d0f7b.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2016

Updated by elippmann on 2016-02-24 10:52:15 +00:00

  • Subject changed from Layout: tabs where designed to be left-aligned to Layout: Tabs should be left-aligned
  • Category set to UI
  • Target Version changed from 273 to 2.2.0

@icinga-migration icinga-migration added this to the 2.2.0 milestone Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.