Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Support relative links in the plugin output #2916
@lippserd: separation of concerns. A plugin cannot and should not know where your Web 2 installation is located. Sometimes it's completely impossible, as multiple web front-ends might serve the same IDO via multiple domains/URLs. Custom actions: they are not related to this issue, links in the Plugin Output should "just work".
Where exactly? If you refer to e.g.
I don't ask because I don't like the idea. I ask because I really need proper examples (the documentation doesn't count) as I see two possible solutions here:
a) A proper base path (e.g.
a) will have a reasonable impact on all relative links currently in use. Previously they were rooted at the current browser location. Once a base path is defined this is not the case anymore. So this will possibly be a breaking change since it also applies to named anchors. (
I like a) more because it's more flexible and future proof. Though, if we don't want such a change or have massive amounts of relative links out in the wild (which I highly doubt) relying on the current behavior I'll stick to b).
The base href is only respected by the browser, not by XHR.
Note that anchor. Any such relative links will not work anymore with #3819. Our JS of course can still process such without the base href. Though, the browser will not.